Skip to content

Commit

Permalink
Remove codecov
Browse files Browse the repository at this point in the history
This continues a trend we've done with other projects.
Codecov has some use in other types of projects, but really isn't a good
fit for Nailgun since it is functionally exercised by Robottelo.

Without getting too deep into philosophy, CodeCov is a misleading metric
for quality and minor changes are largely ignored in mature projects.
  • Loading branch information
JacobCallahan authored and jyejare committed Mar 14, 2024
1 parent a74cabf commit 4dc79ca
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 35 deletions.
7 changes: 0 additions & 7 deletions .codecov.yml

This file was deleted.

9 changes: 0 additions & 9 deletions .github/workflows/merge_to_master.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,6 @@ jobs:
- name: Pre Commit Checks
uses: pre-commit/[email protected]

- name: Test Nailgun Coverage
run: |
make test-coverage
- name: Make Docs
run: |
make docs-html
Expand All @@ -60,11 +56,6 @@ jobs:
if: failure()
run: git diff

- name: Upload Codecov Coverage
uses: codecov/[email protected]
with:
fail_ci_if_error: true

build-n-publish:
name: Build and publish Python 🐍 distributions 📦 to PyPI
runs-on: ubuntu-latest
Expand Down
9 changes: 2 additions & 7 deletions .github/workflows/pull_requests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,8 @@ jobs:
pip install --compile --no-cache-dir pycurl
pip install -U -r requirements.txt -r requirements-dev.txt --no-cache-dir
- name: Test Nailgun Coverage
run: |
make test-coverage
- name: Run Tests
run: make test

- name: Make Docs
run: |
Expand All @@ -56,7 +55,3 @@ jobs:
if: failure()
run: git diff

- name: Upload Codecov Coverage
uses: codecov/[email protected]
with:
fail_ci_if_error: true
6 changes: 1 addition & 5 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ help:
@echo "Please use \`make <target>' where <target> is one of:"
@echo " help to show this message"
@echo " test to run unit tests"
@echo " test-coverage to run unit tests and measure test coverage"
@echo " docs-html to generate HTML documentation"
@echo " docs-clean to remove documentation"
@echo " package to generate installable Python packages"
Expand All @@ -21,9 +20,6 @@ docs-clean:
test:
python $(TEST_OPTIONS)

test-coverage:
coverage run --source nailgun $(TEST_OPTIONS)

package:
./setup.py sdist bdist_wheel --universal

Expand All @@ -33,4 +29,4 @@ package-clean:
publish: package
twine upload dist/*

.PHONY: help docs-html docs-clean test test-coverage package package-clean publish
.PHONY: help docs-html docs-clean test package package-clean publish
3 changes: 0 additions & 3 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,3 @@ combine-as-imports = true
[tool.ruff.mccabe]
max-complexity = 25

[tool.coverage.run]
omit = ["tests/*"]
include = ["nailgun/*.py"]
4 changes: 0 additions & 4 deletions requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,5 @@ wheel
# For `make publish`
twine

# For code coverage
codecov==2.1.13
coverage[toml]

# For linting
ruff

0 comments on commit 4dc79ca

Please sign in to comment.