From a3dc366b2aed3a41c1293d6bca1f3805cd3ea4ae Mon Sep 17 00:00:00 2001
From: Lukas Hellebrandt <lhellebr@redhat.com>
Date: Thu, 1 Feb 2024 19:51:49 +0100
Subject: [PATCH] Fix the test. CV is already published and promoted by
 setup_org_for_a_rh_repo. Also, don't use 2 LCEs needlessly.

---
 tests/foreman/cli/test_host.py | 36 +++++++++++++++++++---------------
 1 file changed, 20 insertions(+), 16 deletions(-)

diff --git a/tests/foreman/cli/test_host.py b/tests/foreman/cli/test_host.py
index 2b9985b5b08..5d31ff5b0af 100644
--- a/tests/foreman/cli/test_host.py
+++ b/tests/foreman/cli/test_host.py
@@ -2012,22 +2012,31 @@ def test_negative_without_attach(
     assert "This system has no repositories available through subscriptions." in repo_list.stdout
 
 
+@pytest.mark.parametrize('sca_enabled', [True, False], ids=['with_sca', 'without_sca'])
 @pytest.mark.cli_host_subscription
 @pytest.mark.tier3
 def test_negative_without_attach_with_lce(
-    target_sat, host_subscription_client, function_org, function_lce
+    target_sat,
+    host_subscription_client,
+    function_org,
+    function_lce,
+    sca_enabled,
 ):
     """Attempt to enable a repository of a subscription that was not
-    attached to a host
+    attached to a host.
     This test is not using the host_subscription entities except
     subscription_name and repository_id
 
     :id: fc469e70-a7cb-4fca-b0ea-3c9e3dfff849
 
-    :expectedresults: repository not enabled on host
+    :expectedresults: Repository enabled with SCA. Failure without SCA.
 
     :parametrized: yes
     """
+    if sca_enabled:
+        function_org.sca_enable()
+    else:
+        function_org.sca_disable()
     content_view = target_sat.api.ContentView(organization=function_org).create()
     ak = target_sat.api.ActivationKey(
         environment=function_lce,
@@ -2046,27 +2055,22 @@ def test_negative_without_attach_with_lce(
         },
         force_use_cdn=True,
     )
-    host_lce = target_sat.api.LifecycleEnvironment(organization=function_org).create()
-    # refresh content view data
-    content_view.publish()
-    content_view.read().version[-1].promote(data={'environment_ids': host_lce.id, 'force': False})
 
     # register client
     host_subscription_client.register_contenthost(
         function_org.name,
-        lce=f'{host_lce.name}/{content_view.name}',
+        lce=f'{function_lce.name}/{content_view.name}',
         auto_attach=False,
     )
 
-    # get list of available subscriptions which are matched with default subscription
-    subscriptions = host_subscription_client.run(
-        f'subscription-manager list --available --matches "{DEFAULT_SUBSCRIPTION_NAME}" --pool-only'
-    )
-    pool_id = subscriptions.stdout.strip()
-    # attach to plain RHEL subsctiption
-    host_subscription_client.subscription_manager_attach_pool([pool_id])
     assert host_subscription_client.subscribed
-    host_subscription_client.enable_repo(REPOS['rhst7']['id'])
+    res = host_subscription_client.enable_repo(REPOS['rhst7']['id'])
+    if sca_enabled:
+        assert res.status == 0
+        assert f"Repository '{REPOS['rhst7']['id']}' is enabled for this system."
+    else:
+        assert res.status != 0
+        assert 'This system has no repositories available through subscriptions' in res.stdout
 
 
 @pytest.mark.e2e