From ecffe7c73f5676a43722dd39476e4ea7406057e8 Mon Sep 17 00:00:00 2001 From: vijaysawant Date: Fri, 31 May 2024 14:30:26 +0530 Subject: [PATCH] addressed review comments, shorten the for loop --- tests/foreman/ui/test_subscription.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/tests/foreman/ui/test_subscription.py b/tests/foreman/ui/test_subscription.py index a3f41f3fbc3..bd24a5a06f7 100644 --- a/tests/foreman/ui/test_subscription.py +++ b/tests/foreman/ui/test_subscription.py @@ -207,12 +207,9 @@ def test_positive_access_with_non_admin_user_with_manifest( with target_sat.ui_session(test_name, user=user.login, password=user_password) as session: all_subscriptions = session.subscription.read_subscriptions() assert len(all_subscriptions) > 0 - for subscription in all_subscriptions: - if subscription['Name'] == DEFAULT_SUBSCRIPTION_NAME: - assert True - break - else: - pytest.fail("Default subsciption not found") + assert any( + [sub['Name'] == DEFAULT_SUBSCRIPTION_NAME for sub in all_subscriptions] + ), 'Default subsciption not found' @pytest.mark.tier2