Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add abstraction for debian repo #13047

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Add abstraction for debian repo #13047

merged 1 commit into from
Nov 21, 2023

Conversation

dosas
Copy link
Collaborator

@dosas dosas commented Nov 7, 2023

Problem Statement

Missing Debian repository abstraction for running robottelo tests on orcharhino.

Solution

Add abstraction for debian repository

@dosas dosas requested a review from a team as a code owner November 7, 2023 08:39
@omkarkhatavkar
Copy link

Can one of the admins verify this patch?

@dosas dosas force-pushed the add-debian-repo-abstraction branch from 0804349 to 1c647ad Compare November 7, 2023 12:07
@omkarkhatavkar omkarkhatavkar added CherryPick PR needs CherryPick to previous branches 6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 labels Nov 7, 2023
ogajduse
ogajduse approved these changes Nov 21, 2023
View reviewed changes
Copy link
Member

@ogajduse ogajduse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this change does not break anything on our end since we do not test DEB repositories, I am fine with merging.

@ogajduse ogajduse enabled auto-merge (rebase) November 21, 2023 12:56
@JacobCallahan
Copy link
Member

@dosas can you rebase your branch and resolve any conflicts?

auto-merge was automatically disabled November 21, 2023 14:18

Head branch was pushed to by a user without write access

@dosas dosas force-pushed the add-debian-repo-abstraction branch from 1c647ad to 77daee6 Compare November 21, 2023 14:18
@dosas
Copy link
Collaborator Author

dosas commented Nov 21, 2023

@JacobCallahan rebase done

@ogajduse ogajduse enabled auto-merge (rebase) November 21, 2023 14:19
@ogajduse ogajduse merged commit 4f16526 into SatelliteQE:master Nov 21, 2023
5 checks passed
This was referenced Nov 21, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogajduse ogajduse ogajduse approved these changes

@jyejare jyejare jyejare approved these changes

@JacobCallahan JacobCallahan JacobCallahan approved these changes

Assignees

@dosas dosas

Labels
6.12.z Introduced in or relating directly to Satellite 6.12 6.13.z Introduced in or relating directly to Satellite 6.13 6.14.z Introduced in or relating directly to Satellite 6.14 CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dosas @omkarkhatavkar @JacobCallahan @jyejare @ogajduse