Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherrypick of 6.15 tests to 6.15.z #13649

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Cherrypick of 6.15 tests to 6.15.z #13649

merged 1 commit into from
Jan 9, 2024

Conversation

sambible
Copy link
Contributor

@sambible sambible commented Jan 8, 2024 •
edited
Loading

Cherrypick of tests that missed the cutover from stream.
Requires: SatelliteQE/airgun#1121

Original PR: #13120

@sambible sambible added the No-CherryPick PR doesnt need CherryPick to previous branches label Jan 8, 2024
@sambible sambible self-assigned this Jan 8, 2024
@sambible sambible requested a review from a team as a code owner January 8, 2024 14:08
@sambible sambible changed the title Adjust tests Cherrypick of 6.15 tests to 6.15.z Jan 8, 2024
vsedmik
vsedmik requested changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we miss the new_host_ui fixture here?

@ColeHiggins2
Copy link
Member

trigger: test-robottelo
airgun: 1121
pytest: tests/foreman/ui/test_host.py -k test_all_hosts_delete or test_all_hosts_bulk_delete

@sambible
Copy link
Contributor Author

sambible commented Jan 8, 2024

trigger: test-robottelo
airgun: 1121
pytest: tests/foreman/ui/test_host.py -k 'test_all_hosts_delete or test_all_hosts_bulk_delete'

vsedmik
vsedmik approved these changes Jan 8, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now, PRT pending.

@vsedmik
Copy link
Contributor

vsedmik commented Jan 9, 2024

PRT failure seems unrelated AND happened in teardown, which means the tests actually passed

22:26:21  >               ':4444', f'/videos/{ui_session.ui_session_id}.mp4'
22:26:21              )
22:26:21  E           AttributeError: 'Session' object has no attribute 'ui_session_id'

@vsedmik vsedmik merged commit b5854b2 into SatelliteQE:6.15.z Jan 9, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vsedmik vsedmik vsedmik approved these changes

Assignees

@sambible sambible

Labels
No-CherryPick PR doesnt need CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sambible @ColeHiggins2 @vsedmik