add locks

Sauceforge · Jan 21, 2025 · 7339e21 · 7339e21
1 parent fb0cddc
commit 7339e21
Show file tree

Hide file tree

Showing 5 changed files with 28 additions and 9 deletions.
diff --git a/Saucery.Core/Dojo/BrowserVersion.cs b/Saucery.Core/Dojo/BrowserVersion.cs
@@ -145,7 +145,14 @@ private void AppendPlatformField(string fieldToAdd)
         {
             lock (TestNameBuilder)
             {
-                TestNameBuilder.Append($"{SauceryConstants.UNDERSCORE}{fieldToAdd}");
+                if (TestNameBuilder.Length == 0)
+                {
+                    TestNameBuilder.Append($"{fieldToAdd}");
+                }
+                else
+                {
+                    TestNameBuilder.Append($"{SauceryConstants.UNDERSCORE}{fieldToAdd}");
+                }
             }
         }
     }

diff --git a/Saucery.Playwright.NUnit/SauceryBase.cs b/Saucery.Playwright.NUnit/SauceryBase.cs
@@ -37,8 +37,10 @@ protected SauceryBase(BrowserVersion browserVersion) =>
     [SetUp]
     public void Setup()
     {
-        _browserVersion!.SetTestName(TestContext.CurrentContext.Test.Name);
-        _testName = _browserVersion.TestName!;
+        lock(_browserVersion!) {
+            _browserVersion!.SetTestName(TestContext.CurrentContext.Test.Name);
+            _testName = _browserVersion.TestName!;
+        }
 
         //DebugMessages.PrintPlatformDetails(platform);
         // set up the desired options

diff --git a/Saucery.TUnit/SauceryTBase.cs b/Saucery.TUnit/SauceryTBase.cs
@@ -15,8 +15,11 @@ public class SauceryTBase : BaseFixture
     protected bool InitialiseDriver(BrowserVersion browserVersion)
     {
         _browserVersion = browserVersion;
-        _browserVersion.SetTestName(GetTestName());
-        _testName = _browserVersion.TestName;
+        lock (browserVersion)
+        {
+            _browserVersion.SetTestName(GetTestName());
+            _testName = _browserVersion.TestName;
+        }
 
         //DebugMessages.PrintPlatformDetails(platform);
         // set up the desired options

diff --git a/Saucery.XUnit/SauceryXBase.cs b/Saucery.XUnit/SauceryXBase.cs
@@ -17,8 +17,12 @@ public class SauceryXBase : XunitContextBase, IClassFixture<BaseFixture>
     protected bool InitialiseDriver(BrowserVersion browserVersion)
     {
         _browserVersion = browserVersion;
-        _browserVersion.SetTestName(GetTestName());
-        _testName = _browserVersion.TestName;
+
+        lock (_browserVersion)
+        {
+            _browserVersion.SetTestName(GetTestName());
+            _testName = _browserVersion.TestName;
+        }
 
         //DebugMessages.PrintPlatformDetails(platform);
         // set up the desired options

diff --git a/Saucery/SauceryBase.cs b/Saucery/SauceryBase.cs
@@ -30,8 +30,11 @@ protected SauceryBase(BrowserVersion browserVersion) : this() =>
     [SetUp]
     public void Setup()
     {
-        _browserVersion?.SetTestName(TestContext.CurrentContext.Test.Name);
-        _testName = _browserVersion?.TestName;
+        lock (_browserVersion!)
+        {
+            _browserVersion?.SetTestName(TestContext.CurrentContext.Test.Name);
+            _testName = _browserVersion?.TestName;
+        }
 
         //DebugMessages.PrintPlatformDetails(platform);
         // set up the desired options