Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub review comments shouldn't apply "needs work" #47

Open
wendtek opened this issue Mar 16, 2017 · 0 comments
Open

GitHub review comments shouldn't apply "needs work" #47

wendtek opened this issue Mar 16, 2017 · 0 comments
Labels

Comments

@wendtek
Copy link

wendtek commented Mar 16, 2017

When using GitHub's review system, a user has 4 options:

  1. Comment
  2. Approve (optionally with comment)
  3. Request changes (optionally with comment)
  4. Comment on specific lines

If a user comments (1) or comments on specific lines (4), it will apply the "needs work" label until that user uses the approve (2) action.

At the very least, I think the comment should not apply "needs work", but it may also be good to accept the ":+1:" and "lgtm" messages from those comments.

@camalot camalot added the bug label Mar 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants