Replace forEach by for...of to be asynchronous and prevent users bein…

…g added and removed on the ticket
Sayrix · Sep 15, 2023 · eca79bb · eca79bb
1 parent 90fff32
commit eca79bb
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/events/interactionCreate.ts b/src/events/interactionCreate.ts
@@ -194,8 +194,8 @@ export default class InteractionCreateEvent extends BaseEvent {
 					}
 				});
 
-				interaction.values.forEach((value) => {
-					(interaction.channel as GuildChannel | null)?.permissionOverwrites.delete(value).catch((e) => console.log(e));
+				for (const value of interaction.values) {
+					await (interaction.channel as GuildChannel | null)?.permissionOverwrites.delete(value).catch((e) => console.log(e));
 
 					log(
 						{
@@ -209,7 +209,7 @@ export default class InteractionCreateEvent extends BaseEvent {
 						},
 						this.client
 					);
-				});
+				};
 
 				interaction
 					.update({

diff --git a/src/utils/createTicket.ts b/src/utils/createTicket.ts
@@ -86,7 +86,7 @@ export const createTicket = async (interaction: StringSelectMenuInteraction | Mo
 			.catch((e) => console.log(e));
 
 		if (client.config.rolesWhoHaveAccessToTheTickets.length > 0) {
-			client.config.rolesWhoHaveAccessToTheTickets.forEach(async (role) => {
+			for (const role of client.config.rolesWhoHaveAccessToTheTickets) {
 				await channel.permissionOverwrites
 					.edit(role, {
 						SendMessages: true,
@@ -96,7 +96,7 @@ export const createTicket = async (interaction: StringSelectMenuInteraction | Mo
 						ViewChannel: true,
 					})
 					.catch((e) => console.log(e));
-			});
+			};
 		}
 		const footer = locale.getSubValue("embeds", "ticketOpened", "footer", "text").replace("ticket.pm", "");
 		if(ticketType.color?.toString().trim() === "") ticketType.color = undefined;