Update Challenge-simple-nft-example last Version Scaffold Stark #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: 0xquantum3labs <[email protected]> Co-authored-by: jrcarlos2000 <[email protected]>
Co-authored-by: 0xquantum3labs <[email protected]> Co-authored-by: jrcarlos2000 <[email protected]> Co-authored-by: gianmalarcon <[email protected]>
Co-authored-by: Eduardo <[email protected]>
…inor] Co-authored-by: Eduardo <[email protected]>
Co-authored-by: Eduardo <[email protected]>
Co-authored-by: jrcarlos2000 <[email protected]> Co-authored-by: gianalarcon <[email protected]> Co-authored-by: Eduardo <[email protected]> Co-authored-by: Eduardo <[email protected]> Co-authored-by: Gabriela del Pilar Rojas <[email protected]> Co-authored-by: Richard <[email protected]> Co-authored-by: Carlos Ramos <[email protected]>
Co-authored-by: CarlosR <[email protected]>
Co-authored-by: CarlosR <[email protected]>
Co-authored-by: CarlosR <[email protected]>
Co-authored-by: Carlos Ramos <[email protected]>
Co-authored-by: Carlos Ramos <[email protected]> Co-authored-by: Gabriela del Pilar Rojas <[email protected]> Co-authored-by: 0xquantum3labs <[email protected]> Co-authored-by: jrcarlos2000 <[email protected]> Co-authored-by: Daniel Calderón Díaz <[email protected]> Co-authored-by: gianmalarcon <[email protected]> Co-authored-by: Ugonna Paul Dike <[email protected]> Co-authored-by: Eduardo <[email protected]> Co-authored-by: Eduardo <[email protected]> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: oceanlvr <[email protected]> Co-authored-by: Quantum3Labs <[email protected]> Co-authored-by: gianalarcon <[email protected]> Co-authored-by: Gabriela del Pilar Rojas <[email protected]> Co-authored-by: Richard <[email protected]> Co-authored-by: CarlosR <[email protected]> Co-authored-by: Abdulhakeem Abdulazeez Ayodeji <[email protected]> Co-authored-by: Ikem <[email protected]> Co-authored-by: Wolf <[email protected]> Co-authored-by: Joseph Chimebuka <[email protected]>
gianalarcon
reviewed
Aug 13, 2024
| @@ -151,7 +151,7 @@ export const Header = () => { | |||
| alt="SE2 logo" | |||
| className="cursor-pointer" | |||
| fill | |||
| src="/challenge-icon-starknet.svg" | |||
There was a problem hiding this comment.
this two .svg are the same for me. We can delete one of them. Lets check and fix it from the scaffold-stark repo. We can fix this from the challenge-base branch
| @@ -34,5 +34,9 @@ export const useScaffoldReadContract = < | |||
| ...(readConfig as any), | |||
| }) as Omit<ReturnType<typeof useContractRead>, "data"> & { | |||
| data: AbiFunctionOutputs<ContractAbi, TFunctionName> | undefined; | |||
| refetch: (options?: { | |||
There was a problem hiding this comment.
we removed this before, and it is not part of scaffold-stark now
| @@ -123,7 +123,7 @@ Prepare your environment variables. | |||
|
|
|||
| > 🦊 Since we have deployed to a public testnet, you will now need to connect using a wallet you own(Argent X or Braavos). | |||
|
|
|||
|  | |||
|  | |||
There was a problem hiding this comment.
remove reference to https link, lets call relative/internal path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update last migration Scaffold Stark
Migrating the latest Scaffold Stark features PR232
Types of change
Comments (optional)