Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create ISO upload example #8

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Create ISO upload example #8

wants to merge 1 commit into from

Conversation

iczerjones
Copy link
Contributor

This is an example of an ISO upload from the local client machine to the Scale Computing cluster

This is an example of an ISO upload from the local client machine to the Scale Computing cluster
Copy link

@andrewjj20 andrewjj20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. wanted a second look by someone before it goes in.

Write-Host "Upload complete - ISO is ready for use"
# Update ISO status to ready
$json = @{
name = "$ISOName"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if you also need to send size here. Thought I would have @The-Gargantuan take a look.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like size is listed as CREATE-ONLY, but I think this would be slightly improved to use a PATCH instead of a POST.

Copy link

@tomlohmuller tomlohmuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but because its been hanging out here for so long: do you mind verifying it works on a recent hypercore product version (probably latest GA to be safe)?

Write-Host "Upload complete - ISO is ready for use"
# Update ISO status to ready
$json = @{
name = "$ISOName"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like size is listed as CREATE-ONLY, but I think this would be slightly improved to use a PATCH instead of a POST.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants