-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create ISO upload example #8
base: master
Are you sure you want to change the base?
Conversation
This is an example of an ISO upload from the local client machine to the Scale Computing cluster
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. wanted a second look by someone before it goes in.
Write-Host "Upload complete - ISO is ready for use" | ||
# Update ISO status to ready | ||
$json = @{ | ||
name = "$ISOName" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure if you also need to send size here. Thought I would have @The-Gargantuan take a look.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like size is listed as CREATE-ONLY, but I think this would be slightly improved to use a PATCH instead of a POST.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but because its been hanging out here for so long: do you mind verifying it works on a recent hypercore product version (probably latest GA to be safe)?
Write-Host "Upload complete - ISO is ready for use" | ||
# Update ISO status to ready | ||
$json = @{ | ||
name = "$ISOName" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like size is listed as CREATE-ONLY, but I think this would be slightly improved to use a PATCH instead of a POST.
This is an example of an ISO upload from the local client machine to the Scale Computing cluster