Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A-Frame Support (for versions >=1.1.0) #16

Open
vulture-boy opened this issue Apr 28, 2022 · 0 comments
Open

A-Frame Support (for versions >=1.1.0) #16

vulture-boy opened this issue Apr 28, 2022 · 0 comments

Comments

@vulture-boy
Copy link

vulture-boy commented Apr 28, 2022

Hello! Appreciate the work that you've put into this.
This is probably outside of the scope of the base DepthKit.js, but I wanted to mention that at present, the available library support for A-Frame does not seem to work with A-Frame versions >=1.1.0 due to the transition from THREE.Geometry to THREE.BufferGeometry in 2019 (if I understand correctly).
https://github.com/juniorxsound/DepthKit-A-Frame

Works just fine with A-Frame 0.8.2, however. From the looks of the code, DepthKit for A-Frame seems to contain a minified version of DepthKit.js inside its core .js file.

In any case, I wanted to bring this up in case anyone was interested supporting the A-Frame community by bringing this extension up to speed, since it seems apparent that the people working on this fork are very knowledgeable on DepthKit.js and the A-Frame support hasn't been updated in 4 years from the looks of things.

Thanks for your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant