Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix OnyxAccordionItem not closing when :open receives a false #2699

Open
2 tasks done
ChristianBecker02 opened this issue Feb 5, 2025 · 0 comments
Open
2 tasks done
Assignees
Labels
dev Requires technical expertise

Comments

@ChristianBecker02
Copy link

Version

1.0.0-beta.146

Description

I am currently trying to add a open all, close all AccordionItems button, and stumbled over the fact that when the :open parameter is set to true, the AccordionItem is correctly opening, but the reverse part - setting it to false does not close the AccordionItem.

Manually it works and in the showcase of the component is marked as it can be toggled between true and false.

But its not working with ref, computed or else and also not with a simple button in the playground.

Reproduction steps

https://playground.onyx.schwarz/?onyxVersion=1.0.0-beta.146#eNp9U01PGzEQ/StT9wJSkj20pzRUQIVUeihVy9FS5XonG4PXtuzZbVCU/87Ym48NIKQc1vOeZ96852zEVQizvkMxF4ukowkEVrnmQgpKUkBC6sJX6UwbfCTYwJ17Wl9p7WNtvJucHm8J26F03RF5B1tYRt+CFMnQ1HNdii+jXhGXRwprKKh02rtEgOugXA0XmXW2VDbheUGXndPEw4B801g8O4eNdLCjz3plO+RLH8Zn6bb55qIaFuR1Fqw0WEXI3wCL2vSgrUqJ184yp0009ZR1kDIOoxSFxsSTdXfFl+XsAsx9QMfdBhmHBoW9nw0fV6hqjCMM4H5lEvCvfYJDR/heeKMW1Yn+ofRKxF70KTJeZRfTpbZGP+bIi6UcezX4UrEx2a3xODERQ4DTVoXZQ/KOn06JQO4AfjfzIZRcO0Y/59OKKKR5Vena8d0arenjzCFVLrTVnnr5D0nx7ESVcTWumSlF7scxbnk+JY5maZoX07Vvg7EY70J+H6cqlLX+/49So9jhZF/XK9SPb9Qf0k7wr4gJY8+mHDBSsUEa4Js/P3HN3wew9XWXLXwH/I3J2y5rHGjXnatZ9ohX1N4WM41r7tPNmtCl/VJZaHGj8Ms/59s7qx/lfpp9Hrn4t8eYe7KBOdpEYvsMR95bjQ==

Confirmations

  • I have checked that there is not already a bug report for my issue.
  • I confirm that are no sensitive information included in this bug report. e.g. credentials, internal project details (for employees of the Schwarz Group) etc.
@larsrickert larsrickert self-assigned this Feb 10, 2025
@larsrickert larsrickert added this to onyx Feb 10, 2025
@github-project-automation github-project-automation bot moved this to New in onyx Feb 10, 2025
@larsrickert larsrickert added the dev Requires technical expertise label Feb 10, 2025
@larsrickert larsrickert moved this from New to In Progress in onyx Feb 10, 2025
@mj-hof mj-hof changed the title [Bug]: OnyxAccordionItem not closing when :open receives a false Fix OnyxAccordionItem not closing when :open receives a false Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Requires technical expertise
Projects
Status: In Progress
Development

No branches or pull requests

2 participants