Skip to content

Commit

Permalink
fix: add type annotation to step parameters in AutoFiniteDiff (#104)
Browse files Browse the repository at this point in the history
  • Loading branch information
gdalle authored Jan 24, 2025
1 parent 2aafe20 commit 531145c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "ADTypes"
uuid = "47edcb42-4c32-4615-8424-f2b9edc5f35b"
authors = ["Vaibhav Dixit <[email protected]>, Guillaume Dalle and contributors"]
version = "1.12.0"
version = "1.12.1"

[deps]
ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
Expand Down
6 changes: 3 additions & 3 deletions src/dense.jl
Original file line number Diff line number Diff line change
Expand Up @@ -116,12 +116,12 @@ Defined by [ADTypes.jl](https://github.com/SciML/ADTypes.jl).
- `relstep`: relative finite difference step size
- `absstep`: absolute finite difference step size
"""
Base.@kwdef struct AutoFiniteDiff{T1, T2, T3} <: AbstractADType
Base.@kwdef struct AutoFiniteDiff{T1, T2, T3, S1, S2} <: AbstractADType
fdtype::T1 = Val(:forward)
fdjtype::T2 = fdtype
fdhtype::T3 = Val(:hcentral)
relstep = nothing
absstep = nothing
relstep::S1 = nothing
absstep::S2 = nothing
end

mode(::AutoFiniteDiff) = ForwardMode()
Expand Down

2 comments on commit 531145c

@gdalle
Copy link
Collaborator Author

@gdalle gdalle commented on 531145c Jan 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/123644

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v1.12.1 -m "<description of version>" 531145cd68e7cbd1ce351935d85c6a59df5752af
git push origin v1.12.1

Please sign in to comment.