Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the relstep and absstep parameters to AutoFiniteDiff #102

Merged
merged 7 commits into from
Jan 21, 2025
Merged

Add the relstep and absstep parameters to AutoFiniteDiff #102

merged 7 commits into from
Jan 21, 2025

Conversation

1-Bart-1
Copy link
Contributor

@1-Bart-1 1-Bart-1 commented Jan 21, 2025 •
edited
Loading

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Fixes #101
Adds the relstep and absstep parameters from the FiniteDiff API

@1-Bart-1 1-Bart-1 mentioned this pull request Jan 21, 2025
Closed
gdalle
gdalle requested changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@gdalle gdalle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nearly good to me, thank you for your contribution! Could you also increment the minor version in Project.toml?

1-Bart-1 and others added 4 commits January 21, 2025 14:16
@1-Bart-1 @gdalle
Fix typo in doc
9e783ca 
Co-authored-by: Guillaume Dalle <[email protected]>
@1-Bart-1 @gdalle
improve step test
14b641f 
Co-authored-by: Guillaume Dalle <[email protected]>
@1-Bart-1 @gdalle
improve step test
a87d7dc 
Co-authored-by: Guillaume Dalle <[email protected]>
@1-Bart-1
update minor version
ca5a814
@1-Bart-1
Copy link
Contributor Author

Done

gdalle
gdalle approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@gdalle gdalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!

@gdalle gdalle merged commit 2aafe20 into SciML:main Jan 21, 2025
5 checks passed
@1-Bart-1 1-Bart-1 deleted the add-finite-step branch January 21, 2025 14:03
This was referenced Jan 23, 2025
Open
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gdalle gdalle gdalle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose step size parameters for FiniteDiff
2 participants
@1-Bart-1 @gdalle