DSL doesn't allow @species to be assigned default values and metadata when using begin ... end syntax
#1054
Labels
Comments
|
This seems to actually be a Symbolics.jl bug. These work: using ModelingToolkit
t = ModelingToolkit.t_nounits
@variables u(t)=1 [input = true, disturbance = true]
@variables begin
u(t) = 1
end
@parameters begin
a = 1
end
@parameters begin
a = 1, [input = true, description = "true"]
endbut this errors julia> @variables begin
u(t) = 1, [input = true]
end
ERROR: syntax: misplaced assignment statement in "[input = true]" around REPL[37]:1
Stacktrace:
[1] top-level scope
@ REPL[37]:1as does julia> @parameters begin
u(t)=1, [input=true]
end
ERROR: syntax: misplaced assignment statement in "[input = true]" around REPL[61]:1
Stacktrace:
[1] top-level scope
@ REPL[61]:1 |
|
This requires someone to update |
|
@jonathanfischer97 these seem fixed if you use ModelingToolkit master now. Can you double check on your end? |
|
This now works for me using the latest Catalyst, MTK, and Symbolics releases, so I am going to close this. Feel free to reopen if that is not the case for you. |
|
Thank you guys! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Can't assign default value AND include species metadata within
@speciesbeginblockTrying to define this reaction network, where
begin ... endblock syntaxE(t)is given a default value as well as metadata (description, tunable)will generate the following error:
Combination of
beginblock, default species assignment, and extra metadata produce the errorIt seems this is a problem with how the DSL is parsing the new
beginblock syntax.Using this syntax and giving a default value, OR metadata, doesn't seem to produce an error. Only the combination of these two specie specifications within a
beginblock produces the error.Additionally, it only affects the
@speciesblock, not@parametersspecies, and uses both for the@parameters, doesn't error.Environment (please complete the following information):
using Pkg; Pkg.status()using Pkg; Pkg.status(; mode = PKGMODE_MANIFEST)versioninfo()The text was updated successfully, but these errors were encountered: