Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular dependency introduced in v0.15.18 #279

Closed
jonniediegelman opened this issue Nov 15, 2024 · 2 comments · Fixed by #280
Closed

Circular dependency introduced in v0.15.18 #279

jonniediegelman opened this issue Nov 15, 2024 · 2 comments · Fixed by #280

Comments

@jonniediegelman
Copy link
Collaborator

@avik-pal , I noticed that since this PR went through, I've been getting this warning:

┌ Warning: Circular dependency detected. Precompilation will be skipped for:
│   ComponentArraysConstructionBaseExt [446cf315-a25e-5b5e-ab26-fb2b63960ee9]
│   ComponentArraysAdaptExt [790f4daf-a4cd-52c9-af90-2799ce9781e5]
└ @ Pkg.API ~/.julia/juliaup/julia-1.10.6+0.aarch64.apple.darwin14/share/julia/stdlib/v1.10/Pkg/src/API.jl:127

Any idea what is causing that?

@jonniediegelman
Copy link
Collaborator Author

I unfortunately don't know enough about how the package extensions work to know how circular dependencies can be introduced. Just looking at those extension files, I can't see anything immediately wrong.

@avik-pal
Copy link
Member

I see what happened. Functors.jl started using ConstructionBase as a default dep in v0.5. Since we have ConstructionBase in ext and Functors as a main dep, it causes this.

I will make a PR moving ConstructionBase to main dep since it is anyways being loaded as a default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants