Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Zygote compat to 0.7 #384

Merged
merged 1 commit into from
Jan 31, 2025
Merged

Conversation

SebastianM-C
Copy link
Contributor

It seems that CompatHelper does not check this one.

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

It seems that CompatHelper does not check this one.
@SebastianM-C
Copy link
Contributor Author

Something strange is going on, the tests timeout after 6h :|

@devmotion
Copy link
Member

It seems that CompatHelper does not check this one.

Possibly because it's only a test dependency?

@SebastianM-C
Copy link
Contributor Author

Huh, it happened again...and it's at the very end where the Zygote tests are run.

@ChrisRackauckas
Copy link
Member

Yes look at the thunks.

@sathvikbhagavan
Copy link
Member

I think it got fixed in Zygote 0.7.4. @ChrisRackauckas, can you retrigger CI?

@ChrisRackauckas ChrisRackauckas merged commit 0f7dfe3 into SciML:master Jan 31, 2025
29 of 48 checks passed
@SebastianM-C SebastianM-C deleted the patch-1 branch January 31, 2025 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants