Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update sde_example.md #741

Merged
merged 1 commit into from
Jul 8, 2024
Merged

Conversation

DoktorMike
Copy link
Contributor

@DoktorMike DoktorMike commented Jul 7, 2024

I believe there's a small mistake in this example as the equation uses σ but in the code we use θ (in two places instead of one).

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

I fixed the consistency with the equations but the functions don't actually make much sense as I see it as f and g should really be using p instead of some global variables μ, κ, θ, σ if I'm not mistaken.

I believe there's a small mistake in this example as the equation uses σ but in the code we use θ (in two places instead of one).
@ChrisRackauckas
Copy link
Member

Yeah, the:

Of course, to fully define this problem, we need to define our constants.

is doing a lot of heavy lifting. We should probably spend a moment sometime in the near future to really get that in good shape.

@ChrisRackauckas ChrisRackauckas merged commit b4ec859 into SciML:master Jul 8, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants