Some automated conversions in saveat #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@utkarsh530 can you check what's going on with Metal? |
|
It should be ready now after the tests pass. |
ChrisRackauckas
commented
Oct 22, 2023
| DiffEqDevTools = "f3b72e0c-5b89-59e1-b016-84e28bfd966d" | ||
| Distributed = "8ba89e20-285c-5b6f-9357-94700520ee1b" | ||
| Flux = "587475ba-b771-5e3f-ad9e-33799f191a9c" | ||
| ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210" | ||
| GPUArraysCore = "46192b85-c4d5-4398-a991-12ede77f4527" | ||
| LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e" | ||
| Metal = "dde4c033-4e86-420c-a63e-0dd931031962" |
There was a problem hiding this comment.
is this intentional?
ChrisRackauckas
commented
Oct 22, 2023
Comment on lines
+21
to
+22
| ## Don't test the problems in which GPUs don't support FP64 completely yet | ||
| ## Creating StepRangeLen causes some param types to be FP64 inferred by `float` function |
There was a problem hiding this comment.
the conversion should change things to Float32?
ChrisRackauckas
commented
Oct 22, 2023
| @@ -0,0 +1,114 @@ | |||
|
|
|||
| # saveat is just a bool here: | |||
There was a problem hiding this comment.
That's not allowed?
|
Merging so I can use it. But I'm still not sure about the bool dispatch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it nicer to use Float32 from R and Python, since you can just
saveat=0.01and it attempts to convert the type to Float32 if the JIT was to Float32