CompatHelper: bump compat for AMDGPU in [weakdeps] to 0.9, (keep existing compat) #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
@DhairyaLGandhi do you know what this might be? https://buildkite.com/julialang/diffeqgpu-dot-jl/builds/1025#018fabca-cf1c-430e-9770-cdc03bbf4148/950-2172 |
ChrisRackauckas
deleted the
compathelper/new_version/2024-05-24-18-08-42-491-02147807294
branch
|
Yes, it's the literal_getproperty returning an ODESolution instead of Tangent. I'm surprised it hasn't been happening more often. I understand some code paths within SciML are written to handle the return type. |
|
What's required to fix this? |
|
It should go away with removing that rule. I can take a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
AMDGPUpackage from0.5, 0.6, 0.7, 0.8to0.5, 0.6, 0.7, 0.8, 0.9.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.