Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

package maintenance #13

Open
isaacsas opened this issue Sep 24, 2023 · 14 comments
Open

package maintenance #13

isaacsas opened this issue Sep 24, 2023 · 14 comments

Comments

@isaacsas
Copy link
Member

@kaandocal would you consider putting this under SciML so we could get more people access to maintain it? You could still have full repo permissons, but having it in an org might help with keeping dependencies updated. Just a thought!

@kaandocal
Copy link
Contributor

Sure, happy to do that - I've not been very up to date with some of the more recent changes to Catalyst and Symbolics, as you might have noticed...

@isaacsas
Copy link
Member Author

No worries! I'm trying hard to keep Catalyst v13 stable and avoid any breaking changes for a while. It was a nice improvement I think and will ultimately allow full (spatial too!) model specification within DSL, but it was breaking. I can't control Symbolics, but the last breaking release had noticeable performance improvements, so I'd say it was worthwhile.

I'll ping you here once you have been added to SciML and can initiate the repo transfer.

@isaacsas
Copy link
Member Author

I just sent you an invite to join SciML. Once you accept you can transfer this repo to the org. I'll make sure you still have full write permissions on it.

@kaandocal
Copy link
Contributor

I appreciate the work on both packages. Unfortunately the invitation link has expired as I had other commitments for the past week or two - if you could please re-send it I will make sure to transfer the repo. Thanks and sorry for the bother!

@isaacsas
Copy link
Member Author

@kaandocal I just sent you another invitation.

@isaacsas
Copy link
Member Author

Sorry for the delay, I was traveling for a week and am still catching up myself on stuff...

@kaandocal
Copy link
Contributor

No worries, the hold-up was on me. Done!

@isaacsas
Copy link
Member Author

Yup, I see it is now working. Is there any reason not to make a new v.3 release with the updated Catalyst support? (i.e. are you aware that there are open issues?)

@isaacsas
Copy link
Member Author

@kaandocal is it ok to make a release of the current version to get the Catalyst 13 support out there?

@sallyseal
Copy link

@kaandocal @isaacsas is FiniteStateProjection.jl compatible with Catalyst 13 now? I'm having an issue with using symbolic stoichiometry matrices. Thanks!

@isaacsas
Copy link
Member Author

It looks like it never got a release for Catalyst 13, but I just started the process.

@sallyseal
Copy link

It looks like it never got a release for Catalyst 13, but I just started the process.

Thanks @isaacsas - will check back

@kaandocal
Copy link
Contributor

@sallyseal The delay is my doing - I mistakenly assumed the updated version would be reflected in the registry automatically.

@kaandocal
Copy link
Contributor

@sallyseal Please let me know if this works for you. Seems like not updating in time created a big mess...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants