Skip to content

Commit

Permalink
restore error_norm keyword for Cubature algs
Browse files Browse the repository at this point in the history
  • Loading branch information
lxvm committed Feb 18, 2024
1 parent 96cb1f0 commit 4b0a887
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions src/algorithms_extension.jl
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ end
abstract type AbstractCubatureJLAlgorithm <: AbstractIntegralExtensionAlgorithm end

"""
CubatureJLh(; norm=Cubature.INDIVIDUAL)
CubatureJLh(; error_norm=Cubature.INDIVIDUAL)
Multidimensional h-adaptive integration from Cubature.jl.
`error_norm` specifies the convergence criterion for vector valued integrands.
Expand All @@ -174,13 +174,13 @@ publisher={Elsevier}
struct CubatureJLh <: AbstractCubatureJLAlgorithm
error_norm::Int32
end
function CubatureJLh(; norm=0)
function CubatureJLh(; error_norm=0)
isnothing(Base.get_extension(@__MODULE__, :IntegralsCubatureExt)) && error("CubatureJLh requires `using Cubature`")
return CubatureJLh(norm)
return CubatureJLh(error_norm)
end

"""
CubatureJLp(; norm=Cubature.INDIVIDUAL)
CubatureJLp(; error_norm=Cubature.INDIVIDUAL)
Multidimensional p-adaptive integration from Cubature.jl.
This method is based on repeatedly doubling the degree of the cubature rules,
Expand All @@ -193,9 +193,9 @@ Defaults to `Cubature.INDIVIDUAL`, other options are
struct CubatureJLp <: AbstractCubatureJLAlgorithm
error_norm::Int32
end
function CubatureJLp(; norm=0)
function CubatureJLp(; error_norm=0)
isnothing(Base.get_extension(@__MODULE__, :IntegralsCubatureExt)) && error("CubatureJLp requires `using Cubature`")
return CubatureJLp(norm)
return CubatureJLp(error_norm)

Check warning on line 198 in src/algorithms_extension.jl

View check run for this annotation

Codecov / codecov/patch

src/algorithms_extension.jl#L196-L198

Added lines #L196 - L198 were not covered by tests
end


Expand Down

0 comments on commit 4b0a887

Please sign in to comment.