Handle cholesky

SciML · Dec 4, 2023 · 12fbcef · 12fbcef
1 parent 72bc014
commit 12fbcef
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/Project.toml b/Project.toml
@@ -102,8 +102,8 @@ SciMLOperators = "0.3"
 Setfield = "1"
 SparseArrays = "1.9"
 Sparspak = "0.3.6"
-Test = "1"
 StaticArraysCore = "1"
+Test = "1"
 UnPack = "1"
 julia = "1.9"
 

diff --git a/src/factorization.jl b/src/factorization.jl
@@ -10,7 +10,7 @@ end
 
 _ldiv!(x, A, b) = ldiv!(x, A, b)
 
-_ldiv!(x::MVector, A, b::SVector) = (x .= A \ b)
+_ldiv!(x, A, b::SVector) = (x .= A \ b)
 _ldiv!(::SVector, A, b::SVector) = (A \ b)
 
 function _ldiv!(x::Vector, A::Factorization, b::Vector)
@@ -285,6 +285,12 @@ else
     end
 end
 
+function init_cacheval(alg::CholeskyFactorization, A::SMatrix, b, u, Pl, Pr,
+    maxiters::Int, abstol, reltol, verbose::Bool,
+    assumptions::OperatorAssumptions)
+    cholesky(A)  # StaticArrays doesn't have the pivot argument. Prevent generic fallback.
+end
+
 function init_cacheval(alg::CholeskyFactorization, A, b, u, Pl, Pr,
     maxiters::Int, abstol, reltol, verbose::Bool,
     assumptions::OperatorAssumptions)