Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispatch on __solve instead of solve #322

Closed
avik-pal opened this issue Jun 7, 2023 · 1 comment · Fixed by #449
Closed

Dispatch on __solve instead of solve #322

avik-pal opened this issue Jun 7, 2023 · 1 comment · Fixed by #449
Labels
good first issue Good for newcomers

Comments

@avik-pal
Copy link
Member

avik-pal commented Jun 7, 2023

Similar to other packages in SciMLverse, we should have the solvers dispatch on __solve. This would allow us to define the adjoint equations in SciMLSensitivity.jl SciML/SciMLSensitivity.jl#808 (comment)
@avik-pal avik-pal mentioned this issue Jun 7, 2023
Closed
@ChrisRackauckas
Copy link
Member

👍 that would be fine.

@ChrisRackauckas ChrisRackauckas added the good first issue Good for newcomers label Oct 26, 2023
@avik-pal avik-pal mentioned this issue Dec 20, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adjoints for Linear Solve SciML/LinearSolve.jl
2 participants
@ChrisRackauckas @avik-pal