Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Enzyme rules with less copying #380

Open
ChrisRackauckas opened this issue Sep 24, 2023 · 1 comment
Open

Improve Enzyme rules with less copying #380

ChrisRackauckas opened this issue Sep 24, 2023 · 1 comment

Comments

@ChrisRackauckas
Copy link
Member

Right now in order to make the first pass of the Enzyme rule there's a lot of defensive copying. I think we can get away with less by putting a good rule over setproperty!(linsolve, ...), since if it knows just when to copy there, it can ensure that the linsolve in reverse is "fixed" as it goes backwards. That would mean that the other rules would not need to copy each time in case of a change, since we would instead be public API point where it can change.

@wsmoses
Copy link
Contributor

wsmoses commented Sep 24, 2023

Yeah I that's correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants