Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add SpringDamper component #327

Merged
merged 3 commits into from
Sep 11, 2024
Merged

add SpringDamper component #327

merged 3 commits into from
Sep 11, 2024

Conversation

baggepinnen
Copy link
Contributor

No description provided.

@baggepinnen
Copy link
Contributor Author

test failures unrelated, the added test passes

@baggepinnen baggepinnen merged commit 197434e into main Sep 11, 2024
6 of 8 checks passed
@baggepinnen baggepinnen deleted the fb/TMSpringDamper branch September 11, 2024 13:28
@ChrisRackauckas
Copy link
Member

It's linearization related though, could you take a look?

https://github.com/SciML/ModelingToolkitStandardLibrary.jl/actions/runs/10811965889/job/29992538529#step:6:199

@baggepinnen
Copy link
Contributor Author

That error has been there for a long time, it's related to a initialization system bug

@baggepinnen
Copy link
Contributor Author

This was the last time tests passed for MTKstdlib, they have never passed on MTKv9
image

@ChrisRackauckas
Copy link
Member

Is there an "initialization bug" for it? What's the report on it?

@baggepinnen
Copy link
Contributor Author

Is there an "initialization bug" for it? What's the report on it?

Not sure, it looks like you were the one who merged the PR that broke the tests?

@baggepinnen
Copy link
Contributor Author

#328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants