Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename wrappers to be consistent with other SciML packages #237

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

avik-pal
Copy link
Member

Not exactly a non-breaking change, but I renamed the wrapped solvers to conform to the other SciML wrappers

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #237 (42d741b) into master (1a0e5ee) will decrease coverage by 93.23%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #237       +/-   ##
==========================================
- Coverage   93.22%   0.00%   -93.23%     
==========================================
  Files          12      12               
  Lines         901     896        -5     
==========================================
- Hits          840       0      -840     
- Misses         61     896      +835     
Files Coverage Δ
src/NonlinearSolve.jl 0.00% <ø> (-85.00%) ⬇️
ext/NonlinearSolveFastLevenbergMarquardtExt.jl 0.00% <0.00%> (-91.67%) ⬇️
ext/NonlinearSolveLeastSquaresOptimExt.jl 0.00% <0.00%> (-95.84%) ⬇️
src/extension_algs.jl 0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChrisRackauckas ChrisRackauckas merged commit 364d7f4 into SciML:master Oct 16, 2023
7 of 10 checks passed
@avik-pal avik-pal deleted the ap/ext branch October 16, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants