Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Julia 1.11 crashes with NonlinearSolve 4 when ReverseDiff is loaded #516

Open
hexaeder opened this issue Dec 4, 2024 · 1 comment
Open
Labels
bug Something isn't working

Comments

@hexaeder
Copy link

hexaeder commented Dec 4, 2024

Describe the bug 🐞

I found a bug in my test suite, where Julia 1.11 would segfault under NonlinearSolve@4.0. Julia 1.10 works with 3 and 4, Julia 1.11 only works with 3.
The curious thing is: it only segfaults after ReverseDiff is loaded. Since ReverseDiff was a stale dependency in my test suit which was loaded in a different @save_testset even, this isn't really a bug for me anymore and I couldn't put to much time into finding a MWE which does not use my Libarary, sorry.

Expected behavior

No segfault 🙃

Minimal Reproducible Example 👇
Note that this will install a specific commit of NetworkDynamics, in which I bumped the compact to 4.0. The library is used to construct the RHS of a ODE, NonlinarSolve is the used to find a fixpoint. It calls the function 2 times, it works before import ReverseDiff and segfaults after.

using Pkg
pkg"activate --temp"
pkg"add NetworkDynamics#8b21567, Graphs, ReverseDiff, SteadyStateDiffEq"
using NetworkDynamics
using Graphs
using SteadyStateDiffEq

function swing_equation(dv, v, esum, p,t)
    P, I, γ = p
    dv[1] = v[2]
    dv[2] = P - γ * v[2] .+ esum[1]
    dv[2] = dv[2] / I
    nothing
end
vertex = VertexModel(f=swing_equation, g=1, sym=[, ], psym=[:P_ref, :I=>1, =>0.1])
function simple_edge(e, v_s, v_d, (K,), t)
    e[1] = K * sin(v_s[1] - v_d[1])
end
edge = EdgeModel(;g=AntiSymmetric(simple_edge), outsym=:P, psym=[:K=>1.63, :limit=>1])

g = SimpleGraph([0 1 1 0 1;
                 1 0 1 1 0;
                 1 1 0 1 0;
                 0 1 1 0 1;
                 1 0 0 1 0])
nw = Network(g, vertex, edge)
# nw is just some callable ode rhs (du, u, p ,t)
# typestable, but has some DiffCaches which I know does something with ReverseDiff

u0 = rand(dim(nw))
p = rand(pdim(nw))
prob = SteadyStateProblem(nw, u0, p)

# this works
solve(prob, SSRootfind())

# segfaults after import
import ReverseDiff
solve(prob, SSRootfind())

Error & Stacktrace ⚠️

Internal error: during type inference of
_solve_fixpoint(SciMLBase.SteadyStateProblem{Array{Float64, 1}, true, Array{Float64, 1}, SciMLBase.ODEFunction{true, SciMLBase.FullSpecialize, NetworkDynamics.Network{NetworkDynamics.SequentialExecution{true}, Graphs.SimpleGraphs.SimpleGraph{Int64}, NetworkDynamics.NetworkLayer{Graphs.SimpleGraphs.SimpleGraph{Int64}, Tuple{NetworkDynamics.ComponentBatch{NetworkDynamics.EdgeModel{nothing, nothing, nothing, nothing, nothing, Nothing}, Nothing, NetworkDynamics.AntiSymmetric{typeof(var"##Cascading Failure.jl#5755".simple_edge)}, NetworkDynamics.PureFeedForward, Static.StaticInt{0}, Static.StaticInt{2}, NamedTuple{(:src, :dst), Tuple{Static.StaticInt{1}, Static.StaticInt{1}}}, NamedTuple{(:src, :dst), Tuple{Static.StaticInt{1}, Static.StaticInt{1}}}, Static.StaticInt{0}, Array{Int64, 1}}}, NetworkDynamics.SequentialAggregator{typeof(Base.:(+))}}, Tuple{NetworkDynamics.ComponentBatch{NetworkDynamics.VertexModel{nothing, nothing, nothing, nothing, nothing, Nothing}, typeof(var"##Cascading Failure.jl#5755".swing_equation), NetworkDynamics.StateMask{1, StaticArraysCore.SArray{Tuple{1}, Int64, 1, 1}}, NetworkDynamics.PureStateMap, Static.StaticInt{2}, Static.StaticInt{3}, Static.StaticInt{1}, Static.StaticInt{1}, Static.StaticInt{0}, Array{Int64, 1}}}, LinearAlgebra.UniformScaling{Bool}, PreallocationTools.DiffCache{Array{Float64, 1}, Array{Float64, 1}}, NetworkDynamics.EagerGBufProvider{Array{Int64, 1}, PreallocationTools.DiffCache{Array{Float64, 1}, Array{Float64, 1}}}, Nothing}, LinearAlgebra.UniformScaling{Bool}, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, Nothing, typeof(SciMLBase.DEFAULT_OBSERVED), Nothing, NetworkDynamics.Network{NetworkDynamics.SequentialExecution{true}, Graphs.SimpleGraphs.SimpleGraph{Int64}, NetworkDynamics.NetworkLayer{Graphs.SimpleGraphs.SimpleGraph{Int64}, Tuple{NetworkDynamics.ComponentBatch{NetworkDynamics.EdgeModel{nothing, nothing, nothing, nothing, nothing, Nothing}, Nothing, NetworkDynamics.AntiSymmetric{typeof(var"##Cascading Failure.jl#5755".simple_edge)}, NetworkDynamics.PureFeedForward, Static.StaticInt{0}, Static.StaticInt{2}, NamedTuple{(:src, :dst), Tuple{Static.StaticInt{1}, Static.StaticInt{1}}}, NamedTuple{(:src, :dst), Tuple{Static.StaticInt{1}, Static.StaticInt{1}}}, Static.StaticInt{0}, Array{Int64, 1}}}, NetworkDynamics.SequentialAggregator{typeof(Base.:(+))}}, Tuple{NetworkDynamics.ComponentBatch{NetworkDynamics.VertexModel{nothing, nothing, nothing, nothing, nothing, Nothing}, typeof(var"##Cascading Failure.jl#5755".swing_equation), NetworkDynamics.StateMask{1, StaticArraysCore.SArray{Tuple{1}, Int64, 1, 1}}, NetworkDynamics.PureStateMap, Static.StaticInt{2}, Static.StaticInt{3}, Static.StaticInt{1}, Static.StaticInt{1}, Static.StaticInt{0}, Array{Int64, 1}}}, LinearAlgebra.UniformScaling{Bool}, PreallocationTools.DiffCache{Array{Float64, 1}, Array{Float64, 1}}, NetworkDynamics.EagerGBufProvider{Array{Int64, 1}, PreallocationTools.DiffCache{Array{Float64, 1}, Array{Float64, 1}}}, Nothing}, Nothing, Nothing}, Base.Pairs{Symbol, Union{}, Tuple{}, NamedTuple{(), Tuple{}}}}, SteadyStateDiffEq.SSRootfind{Nothing})
Encountered unexpected error in runtime:
AssertionError(msg="val.id > 0")
renumber_ssa at ./compiler/ssair/slot2ssa.jl:56
#472 at ./compiler/ssair/slot2ssa.jl:62 [inlined]
ssamap at ./compiler/utilities.jl:360
renumber_ssa! at ./compiler/ssair/slot2ssa.jl:62 [inlined]
renumber_ssa! at ./compiler/ssair/slot2ssa.jl:61 [inlined]
construct_ssa! at ./compiler/ssair/slot2ssa.jl:902
slot2reg at ./compiler/optimize.jl:1219 [inlined]
run_passes_ipo_safe at ./compiler/optimize.jl:994
run_passes_ipo_safe at ./compiler/optimize.jl:1009 [inlined]
optimize at ./compiler/optimize.jl:983
jfptr_optimize_46597.1 at /home/hw/.julia/juliaup/julia-1.11.1+0.x64.linux.gnu/lib/julia/sys.so (unknown line)
finish_nocycle at ./compiler/typeinfer.jl:265
_typeinf at ./compiler/typeinfer.jl:249
# goes on forever

Environment (please complete the following information):

  • Output of using Pkg; Pkg.status()
(jl_4dYjgO) pkg> st
Status `/tmp/jl_4dYjgO/Project.toml`
  [86223c79] Graphs v1.12.0
  [22e9dc34] NetworkDynamics v0.9.2 `https://github.com/JuliaDynamics/NetworkDynamics.jl.git#8b21567`
  [37e2e3b7] ReverseDiff v1.15.3
  [9672c7b4] SteadyStateDiffEq v2.4.1
  • Output of using Pkg; Pkg.status(; mode = PKGMODE_MANIFEST)
(jl_4dYjgO) pkg> st -m
Status `/tmp/jl_4dYjgO/Manifest.toml`
  [47edcb42] ADTypes v1.11.0
  [1520ce14] AbstractTrees v0.4.5
  [7d9f7c33] Accessors v0.1.38
  [79e6a3ab] Adapt v4.1.1
  [66dad0bd] AliasTables v1.1.3
  [dce04be8] ArgCheck v2.4.0
  [ec485272] ArnoldiMethod v0.4.0
  [4fba245c] ArrayInterface v7.17.1
  [4c555306] ArrayLayouts v1.10.4
⌅ [a9b6321e] Atomix v0.1.0
  [e2ed5e7c] Bijections v0.1.9
  [62783981] BitTwiddlingConvenienceFunctions v0.1.6
  [70df07ce] BracketingNonlinearSolve v1.1.0
  [fa961155] CEnum v0.5.0
  [2a0fbf3d] CPUSummary v0.2.6
  [7057c7e9] Cassette v0.3.14
  [d360d2e6] ChainRulesCore v1.25.0
  [fb6a15b2] CloseOpenIntervals v0.1.13
  [861a8166] Combinatorics v1.0.2
  [38540f10] CommonSolve v0.2.4
  [bbf7d656] CommonSubexpressions v0.3.1
  [f70d9fcc] CommonWorldInvalidations v1.0.0
  [34da2185] Compat v4.16.0
  [b152e2b5] CompositeTypes v0.1.4
  [a33af91c] CompositionsBase v0.1.2
  [2569d6c7] ConcreteStructs v0.2.3
  [187b0558] ConstructionBase v1.5.8
  [adafc99b] CpuId v0.3.1
  [9a962f9c] DataAPI v1.16.0
  [864edb3b] DataStructures v0.18.20
  [e2d170a0] DataValueInterfaces v1.0.0
  [2b5f629d] DiffEqBase v6.160.0
  [459566f4] DiffEqCallbacks v4.2.2
  [163ba53b] DiffResults v1.1.0
  [b552c78f] DiffRules v1.15.1
  [a0c0ee7d] DifferentiationInterface v0.6.24
  [31c24e10] Distributions v0.25.113
  [ffbed154] DocStringExtensions v0.9.3
  [5b8099bc] DomainSets v0.7.14
  [7c1d4256] DynamicPolynomials v0.6.1
  [4e289a0a] EnumX v1.0.4
  [f151be2c] EnzymeCore v0.8.7
  [e2ba6199] ExprTools v0.1.10
⌅ [6b7a57c9] Expronicon v0.8.5
  [7034ab61] FastBroadcast v0.3.5
  [9aa1b823] FastClosures v0.3.2
  [29a986be] FastLapackInterface v2.0.4
  [a4df4552] FastPower v1.1.1
  [1a297f60] FillArrays v1.13.0
  [6a86dc24] FiniteDiff v2.26.2
  [1fa38f19] Format v1.3.7
  [f6369f11] ForwardDiff v0.10.38
  [f62d2435] FunctionProperties v0.1.2
  [069b7b12] FunctionWrappers v1.1.3
  [77dc65aa] FunctionWrappersWrappers v0.1.3
  [d9f16b24] Functors v0.5.2
  [46192b85] GPUArraysCore v0.2.0
  [86223c79] Graphs v1.12.0
  [3e5b6fbb] HostCPUFeatures v0.1.17
  [34004b35] HypergeometricFunctions v0.3.25
  [615f187c] IfElse v0.1.1
  [d25df0c9] Inflate v0.1.5
  [18e54dd8] IntegerMathUtils v0.1.2
  [8197267c] IntervalSets v0.7.10
  [3587e190] InverseFunctions v0.1.17
  [92d709cd] IrrationalConstants v0.2.2
  [82899510] IteratorInterfaceExtensions v1.0.0
  [692b3bcd] JLLWrappers v1.6.1
  [ef3ab10e] KLU v0.6.0
  [63c18a36] KernelAbstractions v0.9.30
  [ba0b0d4f] Krylov v0.9.8
  [929cbde3] LLVM v9.1.3
  [b964fa9f] LaTeXStrings v1.4.0
  [23fbe1c1] Latexify v0.16.5
  [10f19ff3] LayoutPointers v0.1.17
  [5078a376] LazyArrays v2.2.4
  [87fe0de2] LineSearch v0.1.4
  [7ed4a6bd] LinearSolve v2.38.0
  [2ab3a3ac] LogExpFunctions v0.3.28
  [bdcacae8] LoopVectorization v0.12.171
  [d8e11817] MLStyle v0.4.17
  [1914dd2f] MacroTools v0.5.13
  [d125e4d3] ManualMemory v0.1.8
  [bb5d69b7] MaybeInplace v0.1.4
  [e1d29d7a] Missings v1.2.0
  [2a8e4939] Mixers v0.1.2
  [46d2c3a1] MuladdMacro v0.2.4
  [102ac46a] MultivariatePolynomials v0.5.7
  [d8a4904e] MutableArithmetics v1.6.0
  [872c559c] NNlib v0.9.26
  [77ba4419] NaNMath v1.0.2
  [22e9dc34] NetworkDynamics v0.9.2 `https://github.com/JuliaDynamics/NetworkDynamics.jl.git#8b21567`
  [8913a72c] NonlinearSolve v4.2.0
  [be0214bd] NonlinearSolveBase v1.3.3
  [5959db7a] NonlinearSolveFirstOrder v1.1.0
  [9a2c21bd] NonlinearSolveQuasiNewton v1.0.0
  [26075421] NonlinearSolveSpectralMethods v1.0.0
  [6fe1bfb0] OffsetArrays v1.14.1
  [bac558e1] OrderedCollections v1.7.0
  [90014a1f] PDMats v0.11.31
  [d96e819e] Parameters v0.12.3
  [f517fe37] Polyester v0.7.16
  [1d0040c9] PolyesterWeave v0.2.2
  [d236fae5] PreallocationTools v0.4.24
  [aea7be01] PrecompileTools v1.2.1
  [21216c6a] Preferences v1.4.3
  [27ebfcd6] Primes v0.5.6
  [43287f4e] PtrArrays v1.2.1
  [1fd47b50] QuadGK v2.11.1
  [3cdcf5f2] RecipesBase v1.3.4
  [731186ca] RecursiveArrayTools v3.27.4
  [f2c3362d] RecursiveFactorization v0.2.23
  [189a3867] Reexport v1.2.2
  [ae029012] Requires v1.3.0
  [37e2e3b7] ReverseDiff v1.15.3
  [79098fc4] Rmath v0.8.0
  [7e49a35a] RuntimeGeneratedFunctions v0.5.13
  [94e857df] SIMDTypes v0.1.0
  [476501e8] SLEEFPirates v0.6.43
  [0bca4576] SciMLBase v2.65.1
  [19f34311] SciMLJacobianOperators v0.1.1
  [c0aeaf25] SciMLOperators v0.3.12
  [53ae85a6] SciMLStructures v1.6.1
  [efcf1570] Setfield v1.1.1
  [727e6d20] SimpleNonlinearSolve v2.0.0
  [699a6c99] SimpleTraits v0.9.4
  [a2af1166] SortingAlgorithms v1.2.1
  [0a514795] SparseMatrixColorings v0.4.10
  [e56a9233] Sparspak v0.3.9
  [276daf66] SpecialFunctions v2.4.0
  [aedffcd0] Static v1.1.1
  [0d7ed370] StaticArrayInterface v1.8.0
  [90137ffa] StaticArrays v1.9.8
  [1e83bf80] StaticArraysCore v1.4.3
  [10745b16] Statistics v1.11.1
  [82ae8749] StatsAPI v1.7.0
  [2913bbd2] StatsBase v0.34.3
  [4c63d2b9] StatsFuns v1.3.2
  [9672c7b4] SteadyStateDiffEq v2.4.1
  [7792a7ef] StrideArraysCore v0.5.7
  [2efcf032] SymbolicIndexingInterface v0.3.35
  [19f23fe9] SymbolicLimits v0.2.2
  [d1185830] SymbolicUtils v3.7.2
⌅ [0c5d862f] Symbolics v6.19.0
  [3783bdb8] TableTraits v1.0.1
  [bd369af6] Tables v1.12.0
  [8ea1fca8] TermInterface v2.0.0
  [8290d209] ThreadingUtilities v0.5.2
  [a759f4b9] TimerOutputs v0.5.25
  [d5829a12] TriangularSolve v0.2.1
  [781d530d] TruncatedStacktraces v1.4.0
  [3a884ed6] UnPack v1.0.2
  [a7c27f48] Unityper v0.1.6
  [013be700] UnsafeAtomics v0.2.1
  [d80eeb9a] UnsafeAtomicsLLVM v0.2.2
  [3d5dd08c] VectorizationBase v0.21.71
  [1d5cc7b8] IntelOpenMP_jll v2024.2.1+0
  [dad2f222] LLVMExtra_jll v0.0.34+0
  [856f044c] MKL_jll v2024.2.0+0
  [efe28fd5] OpenSpecFun_jll v0.5.5+0
  [f50d1b31] Rmath_jll v0.5.1+0
  [1317d2d5] oneTBB_jll v2021.12.0+0
  [0dad84c5] ArgTools v1.1.2
  [56f22d72] Artifacts v1.11.0
  [2a0f44e3] Base64 v1.11.0
  [ade2ca70] Dates v1.11.0
  [8ba89e20] Distributed v1.11.0
  [f43a241f] Downloads v1.6.0
  [7b1f6079] FileWatching v1.11.0
  [9fa8497b] Future v1.11.0
  [b77e0a4c] InteractiveUtils v1.11.0
  [4af54fe1] LazyArtifacts v1.11.0
  [b27032c2] LibCURL v0.6.4
  [76f85450] LibGit2 v1.11.0
  [8f399da3] Libdl v1.11.0
  [37e2e46d] LinearAlgebra v1.11.0
  [56ddb016] Logging v1.11.0
  [d6f4376e] Markdown v1.11.0
  [a63ad114] Mmap v1.11.0
  [ca575930] NetworkOptions v1.2.0
  [44cfe95a] Pkg v1.11.0
  [de0858da] Printf v1.11.0
  [9a3f8284] Random v1.11.0
  [ea8e919c] SHA v0.7.0
  [9e88b42a] Serialization v1.11.0
  [1a1011a3] SharedArrays v1.11.0
  [6462fe0b] Sockets v1.11.0
  [2f01184e] SparseArrays v1.11.0
  [f489334b] StyledStrings v1.11.0
  [4607b0f0] SuiteSparse
  [fa267f1f] TOML v1.0.3
  [a4e569a6] Tar v1.10.0
  [8dfed614] Test v1.11.0
  [cf7118a7] UUIDs v1.11.0
  [4ec0a83e] Unicode v1.11.0
  [e66e0078] CompilerSupportLibraries_jll v1.1.1+0
  [deac9b47] LibCURL_jll v8.6.0+0
  [e37daf67] LibGit2_jll v1.7.2+0
  [29816b5a] LibSSH2_jll v1.11.0+1
  [c8ffd9c3] MbedTLS_jll v2.28.6+0
  [14a3606d] MozillaCACerts_jll v2023.12.12
  [4536629a] OpenBLAS_jll v0.3.27+1
  [05823500] OpenLibm_jll v0.8.1+2
  [bea87d4a] SuiteSparse_jll v7.7.0+0
  [83775a58] Zlib_jll v1.2.13+1
  [8e850b90] libblastrampoline_jll v5.11.0+0
  [8e850ede] nghttp2_jll v1.59.0+0
  [3f19e933] p7zip_jll v17.4.0+2
Info Packages marked with ⌅ have new versions available but compatibility constraints restrict them from upgrading. To see why use `status --outdated -m`
  • Output of versioninfo()
julia> versioninfo()
Julia Version 1.11.1
Commit 8f5b7ca12ad (2024-10-16 10:53 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
  CPU: 16 × AMD Ryzen 9 8945HS w/ Radeon 780M Graphics
  WORD_SIZE: 64
  LLVM: libLLVM-16.0.6 (ORCJIT, znver3)
Threads: 16 default, 0 interactive, 8 GC (on 16 virtual cores)
Environment:
  JULIA_NUM_THREADS = auto
  JULIA_PKG_PRESERVE_TIERED_INSTALLED = true

Additional context

Add any other context about the problem here.

@hexaeder hexaeder added the bug Something isn't working label Dec 4, 2024
hexaeder added a commit to JuliaDynamics/NetworkDynamics.jl that referenced this issue Dec 4, 2024
@avik-pal
Copy link
Member

The reason this is triggered based on package loading, is how the automatic AD backend selection happens. That said this is the first time I have seen that error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants