Skip to content

Commit

Permalink
refactor: call complete on models in MTKExt
Browse files Browse the repository at this point in the history
  • Loading branch information
AayushSabharwal committed Feb 2, 2024
1 parent 4c47599 commit 2b891ef
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions ext/OptimizationMTKExt.jl
Original file line number Diff line number Diff line change
Expand Up @@ -10,11 +10,11 @@ function Optimization.instantiate_function(f, x, adtype::AutoModelingToolkit, p,
num_cons = 0)
p = isnothing(p) ? SciMLBase.NullParameters() : p

sys = ModelingToolkit.modelingtoolkitize(OptimizationProblem(f, x, p;
sys = complete(ModelingToolkit.modelingtoolkitize(OptimizationProblem(f, x, p;

Check warning on line 13 in ext/OptimizationMTKExt.jl

View check run for this annotation

Codecov / codecov/patch

ext/OptimizationMTKExt.jl#L13

Added line #L13 was not covered by tests
lcons = fill(0.0,
num_cons),
ucons = fill(0.0,
num_cons)))
num_cons))))
#sys = ModelingToolkit.structural_simplify(sys)
f = OptimizationProblem(sys, x, p, grad = true, hess = true,
sparse = adtype.obj_sparse, cons_j = true, cons_h = true,
Expand Down Expand Up @@ -56,11 +56,11 @@ function Optimization.instantiate_function(f, cache::Optimization.ReInitCache,
adtype::AutoModelingToolkit, num_cons = 0)
p = isnothing(cache.p) ? SciMLBase.NullParameters() : cache.p

sys = ModelingToolkit.modelingtoolkitize(OptimizationProblem(f, cache.u0, cache.p;
sys = complete(ModelingToolkit.modelingtoolkitize(OptimizationProblem(f, cache.u0, cache.p;

Check warning on line 59 in ext/OptimizationMTKExt.jl

View check run for this annotation

Codecov / codecov/patch

ext/OptimizationMTKExt.jl#L59

Added line #L59 was not covered by tests
lcons = fill(0.0,
num_cons),
ucons = fill(0.0,
num_cons)))
num_cons))))
#sys = ModelingToolkit.structural_simplify(sys)
f = OptimizationProblem(sys, cache.u0, cache.p, grad = true, hess = true,
sparse = adtype.obj_sparse, cons_j = true, cons_h = true,
Expand Down

0 comments on commit 2b891ef

Please sign in to comment.