Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[do not merge] rerun CI #645

Closed
wants to merge 1 commit into from

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6fc5804) 0.00% compared to head (7b17227) 7.55%.

Additional details and impacted files
@@            Coverage Diff            @@
##           master    #645      +/-   ##
=========================================
+ Coverage    0.00%   7.55%   +7.55%     
=========================================
  Files          12      40      +28     
  Lines        1141    2699    +1558     
=========================================
+ Hits            0     204     +204     
- Misses       1141    2495    +1354     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Vaibhavdixit02
Copy link
Member

Since the last release was broken I guess we'd have to do another release with the correct compat bounds, could you put that together?

@AayushSabharwal
Copy link
Member Author

AayushSabharwal commented Dec 16, 2023

I think the compat bounds are correct, it just hasn't recognized that MTKv8.74 is out. This is what it (docs) resolves to locally:

Status `~/Julia/SciML/Optimization.jl/docs/Project.toml`
  [7c4d4715] AmplNLWriter v1.2.0
  [e30172f5] Documenter v1.2.1
  [6a86dc24] FiniteDiff v2.21.1
  [587475ba] Flux v0.14.7
  [f6369f11] ForwardDiff v0.10.36
  [87dc4568] HiGHS v1.7.5
  [b6b21f68] Ipopt v1.5.1
  [c8e1da08] IterTools v1.8.0
  [2ddba703] Juniper v0.9.1
  [961ee093] ModelingToolkit v8.74.0
⌅ [76087f3c] NLopt v0.6.5
  [7f7a1694] Optimization v3.20.0
  [3e6eede4] OptimizationBBO v0.1.5
  [bd407f91] OptimizationCMAEvolutionStrategy v0.1.4
  [cb963754] OptimizationEvolutionary v0.1.3
  [6f0a0517] OptimizationGCMAES v0.1.6
  [fd9f6733] OptimizationMOI v0.1.16
  [3aafef2f] OptimizationMetaheuristics v0.1.3
  [e4316d97] OptimizationMultistartOptimization v0.1.4
  [4e6fcdb7] OptimizationNLopt v0.1.8
  [2cab0595] OptimizationNOMAD v0.1.3
  [36348300] OptimizationOptimJL v0.1.14
  [42dfb2eb] OptimizationOptimisers v0.1.6
  [72f8369c] OptimizationPRIMA v0.0.1
  [500b13db] OptimizationPolyalgorithms v0.1.2
  [3d669222] OptimizationSpeedMapping v0.1.5
  [1dea7af3] OrdinaryDiffEq v6.63.0
  [37e2e3b7] ReverseDiff v1.15.1
  [0bca4576] SciMLBase v2.11.0
  [1ed8b502] SciMLSensitivity v7.49.0
  [9f7883ad] Tracker v0.2.30
  [e88e6eb3] Zygote v0.6.67
⌅ [9cc047cb] Ipopt_jll v300.1400.400+0

@AayushSabharwal
Copy link
Member Author

Yep looks like docs resolves properly now.

@AayushSabharwal
Copy link
Member Author

AayushSabharwal commented Dec 18, 2023

The doc failures seem to be because [`ADType`](@ref) and [OptimizationFunction](@ref) are not found in the docstring for OptimizationProblem, and because [Callback Functions](@ref) and [Defining Optimization Functions via AD](@ref) are not found in the docstring for OptimizationFunction (all of these docstrings are in SciMLBase)

  • ADType doesn't seem to be a docstring anywhere. The closest I can find is this but I'm not sure how we'd link that (without just using the URL outright) in SciMLBase
  • OptimizationFunction is a straightforward fix (needs backticks)
  • I guess the issue with the other two is that the headings are defined inside other docstrings, so Documenter can't find them while processing Optimization.jl docs since it (my guess) doesn't go through all the docstrings in all depenencies

@Vaibhavdixit02
Copy link
Member

I guess the issue with the other two is that the headings are defined inside other docstrings, so Documenter can't find them while processing Optimization.jl docs since it (my guess) doesn't go through all the docstrings in all depenencies

Yeah this should work I am not sure why it has an issue I haven't figured it out yet either

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants