Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation does not reflect deprecation of linear indexing #343

Open
j-fu opened this issue Jan 25, 2024 · 2 comments
Open

Documentation does not reflect deprecation of linear indexing #343

j-fu opened this issue Jan 25, 2024 · 2 comments
Labels

Comments

@j-fu
Copy link

j-fu commented Jan 25, 2024

The documentation does not reflect the deprecation of linear indexing (which I find a bit sad BTW):

A[i] # Returns the ith array in the vector of arrays

@j-fu j-fu added the bug label Jan 25, 2024
@ChrisRackauckas
Copy link
Member

which I find a bit sad BTW

Note that we are doing this in order to bring it back in the future, but under a proper AbstractArray definition, i.e. that it is A[i * nj] = A[i,j] like a matrix. Currently this is not true because A[i] returns the i'th column, which makes it not an AbstractArray, which then breaks a lot of downstream integration. So we plan to bring this back as an AbstractArray (this is the bigger change, removing <: AbstractArray because it's required to ensure AD correctness), but since that would change the meaning of A[i] we need a deprecation period so as to help people update their code before imposing a new meaning to it.

@j-fu
Copy link
Author

j-fu commented Jan 25, 2024

Ah ok. Sounds reasonable. I already had the idea to make my own getindex for my subtype, so
may be this strategy should be explained a bit in the docs.
My code doesn't depend on it, but a couple of examples, so I will just update them at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants