Make ODEProblem into a mutable struct #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure we can take that since the semantics of a mutable struct vs struct will make it harder on parallelism. We should chat about this. |
Codecov Report
@@ Coverage Diff @@
## master #496 +/- ##
==========================================
- Coverage 57.27% 53.55% -3.73%
==========================================
Files 50 50
Lines 3703 3701 -2
==========================================
- Hits 2121 1982 -139
- Misses 1582 1719 +137
... and 21 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for use in a reverse-mode EnzymeRule. Otherwise there is a mixed activity for having both floats and vector{floats}, not behind a pointer.