Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promote initial state when converting from non-homogeneous python lists. #527

Merged
merged 4 commits into from
Oct 21, 2023

Conversation

LilithHafner
Copy link
Member

Fixes the problem reported in SciML/diffeqpy#111 (comment)

@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Merging #527 (9cb74b4) into master (187e884) will increase coverage by 0.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #527      +/-   ##
==========================================
+ Coverage   56.29%   56.35%   +0.05%     
==========================================
  Files          53       53              
  Lines        3929     3934       +5     
==========================================
+ Hits         2212     2217       +5     
  Misses       1717     1717              
Files Coverage Δ
ext/SciMLBasePythonCallExt.jl 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LilithHafner
Copy link
Member Author

Waiting for test to fail before pushing the fix

@LilithHafner LilithHafner marked this pull request as ready for review October 20, 2023 15:36
@LilithHafner
Copy link
Member Author

Python tests finally passed :)

@ChrisRackauckas ChrisRackauckas merged commit eab57db into SciML:master Oct 21, 2023
64 of 70 checks passed
@LilithHafner LilithHafner deleted the lh/promote branch October 21, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants