Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and test handling of UnionAll in isinplace checks #530

Merged
merged 2 commits into from
Oct 25, 2023

Conversation

ChrisRackauckas
Copy link
Member

Fixes #529

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #530 (889ee22) into master (c8c3a16) will decrease coverage by 1.23%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #530      +/-   ##
==========================================
- Coverage   56.35%   55.13%   -1.23%     
==========================================
  Files          53       53              
  Lines        3934     3936       +2     
==========================================
- Hits         2217     2170      -47     
- Misses       1717     1766      +49     
Files Coverage Δ
src/utils.jl 67.08% <100.00%> (+1.06%) ⬆️

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChrisRackauckas ChrisRackauckas merged commit b1d71ed into master Oct 25, 2023
64 of 70 checks passed
@ChrisRackauckas ChrisRackauckas deleted the unionall branch October 25, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

isinplace fails due to UnionAll has no field parameters
1 participant