BatchIntegralFunction revisions #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #535 +/- ##
==========================================
- Coverage 56.04% 54.98% -1.06%
==========================================
Files 54 54
Lines 3981 3988 +7
==========================================
- Hits 2231 2193 -38
- Misses 1750 1795 +45
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr is needed by Integrals.jl so that the new interface introduced in SciMLBasev2 can correctly reproduce the old behavior. Mainly, the documentation now says that the integrand prototypes are arrays of the same kind as what the integrand will consume, and integral algorithms are responsible for providing those same arrays.
The only additional thing I added were
getpropertymethods for the bounds of the integration domain. Although these will no longer be used by the updated Integrals.jl, it could help avoid bugs for users migrating to the new version.