Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trajectories based EnsembleProblem(::OptimizationProblem...) method to avoid QMC dep #557

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

Vaibhavdixit02
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the ScioML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9fdb9c8) 25.91% compared to head (022811a) 29.12%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #557      +/-   ##
==========================================
+ Coverage   25.91%   29.12%   +3.20%     
==========================================
  Files          53       53              
  Lines        4140     4141       +1     
==========================================
+ Hits         1073     1206     +133     
+ Misses       3067     2935     -132     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChrisRackauckas ChrisRackauckas merged commit ac664d1 into master Dec 12, 2023
34 of 42 checks passed
@ChrisRackauckas ChrisRackauckas deleted the Vaibhavdixit02-patch-1 branch December 12, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants