fix nlprob to match the initialization system #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it's not documented now? |
|
I matched the initialization system |
|
oh @ChrisRackauckas, the reason you were confused is that I forgot to add the new file. |
|
no import? |
|
fixed |
ChrisRackauckas
approved these changes
Nov 14, 2024
|
Issues with include order seen in tests. |
|
yeah. the issue is that the fields can't be type restricted since there otherwise is no order the files can be ordered in that avoids circular dependency |
|
this should work now. |
|
@ChrisRackauckas pretty sure all CI errors are very unrelated. Merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds the docs from #844 and adds all the extra pieces needed to make this the same as what the initialization system uses.