Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PyCall extension #502

Merged
merged 18 commits into from
Oct 5, 2023
Merged

Conversation

LilithHafner
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #502 (931449c) into master (75b1925) will increase coverage by 2.92%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #502      +/-   ##
==========================================
+ Coverage   53.37%   56.29%   +2.92%     
==========================================
  Files          50       51       +1     
  Lines        3798     3803       +5     
==========================================
+ Hits         2027     2141     +114     
+ Misses       1771     1662     -109     
Files Coverage Δ
ext/PyCallExt.jl 100.00% <100.00%> (ø)

... and 24 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LilithHafner
Copy link
Member Author

I'm not sure how to make sense of the test failures. The last merged PR had 55/72 successes, this has 54/71. Tests pass locally for me.

@ChrisRackauckas
Copy link
Member

It's not you it's me 😅

We just did the v2 release yesterday, and this is package used by hundreds of other packages so the breaking update will take awhile to propagate through all of the downstream packages and pass.

@LilithHafner
Copy link
Member Author

What's the status here? Is there anything I should do to help?

@LilithHafner LilithHafner mentioned this pull request Oct 3, 2023
3 tasks
@ChrisRackauckas
Copy link
Member

The tests are failing because it doesn't find pyjulia to be installed. Try moving the conda pip stuff to before the pycall is loaded? Somehow it needs to install that package on the Julia side to test it

@LilithHafner
Copy link
Member Author

Ah, lovely! And I can use this CI failure as a guide, thanks!

@LilithHafner
Copy link
Member Author

Here's a quote from the last CI failure: "Defaulting to user installation because normal site-packages is not writeable"

@LilithHafner
Copy link
Member Author

Python tests pass! 🎉

@ChrisRackauckas
Copy link
Member

Awesome, thanks for pushing through it!

@ChrisRackauckas ChrisRackauckas merged commit aeb491a into SciML:master Oct 5, 2023
57 of 70 checks passed
@LilithHafner LilithHafner deleted the lh/PyCall-extension branch October 5, 2023 20:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants