-
-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add PyCall extension #502
Add PyCall extension #502
Conversation
Codecov Report
@@ Coverage Diff @@
## master #502 +/- ##
==========================================
+ Coverage 53.37% 56.29% +2.92%
==========================================
Files 50 51 +1
Lines 3798 3803 +5
==========================================
+ Hits 2027 2141 +114
+ Misses 1771 1662 -109
... and 24 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I'm not sure how to make sense of the test failures. The last merged PR had 55/72 successes, this has 54/71. Tests pass locally for me. |
It's not you it's me 😅 We just did the v2 release yesterday, and this is package used by hundreds of other packages so the breaking update will take awhile to propagate through all of the downstream packages and pass. |
9c7a0b4
to
dc7ad0f
Compare
dc7ad0f
to
5dc9d56
Compare
5dc9d56
to
bf14eb3
Compare
024a250
to
a07934b
Compare
What's the status here? Is there anything I should do to help? |
The tests are failing because it doesn't find pyjulia to be installed. Try moving the conda pip stuff to before the pycall is loaded? Somehow it needs to install that package on the Julia side to test it |
Ah, lovely! And I can use this CI failure as a guide, thanks! |
Here's a quote from the last CI failure: "Defaulting to user installation because normal site-packages is not writeable" |
Python tests pass! 🎉 |
Awesome, thanks for pushing through it! |
No description provided.