Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize all repositories to the new and improved setup #24

Closed
6 of 7 tasks
ChrisRackauckas opened this issue Jun 22, 2022 · 9 comments
Closed
6 of 7 tasks

Standardize all repositories to the new and improved setup #24

ChrisRackauckas opened this issue Jun 22, 2022 · 9 comments

Comments

@ChrisRackauckas
Copy link
Member

ChrisRackauckas commented Jun 22, 2022

This includes:

Anything missed?

@isaacsas
Copy link
Member

I don't know if having the download count is really needed or even wanted for all packages. Particularly for newer repos it will be quite low so not so great as an advertisement to use the package.

Is there any reason you are dropping Coveralls from the badges? I usually find its coverage reports much more useful to go through interactively than codecov.

@ChrisRackauckas
Copy link
Member Author

I think codecov is the only one that properly pools all of the statistics, so Coveralls will drop downstream, documentation, and buildkite coverage files.

@YichengDWu
Copy link

YichengDWu commented Jun 23, 2022

It seems like the current formatting CI will not format markdown files. Maybe we should add format_md? I could be wrong tho.

@YichengDWu
Copy link

changing format(".", verbose=true) to format(".", verbose=true, format_markdown=true) would be good

@ChrisRackauckas
Copy link
Member Author

format_markdown seems to cause some errors 😅 so I'm skipping over that for now. I think a good 80% here is just to format all repos and give it the new docs setup, so I'll try to do that today, and then over the next month be going around to example formatter and fix JuliaFormtter.jl issues.

@YingboMa did you run into the format_markdown errors?

@ChrisRackauckas
Copy link
Member Author

Alright, the massive reorganization is starting to see the light at the end of the tunnel.

DiffEqJump -> JumpProcesses still needs to be done.

The formatter hit a lot of errors which were captured here: domluna/JuliaFormatter.jl#610, so those repos will not have the formatter on them at least for now until that gets cleaned up.

Someone needs to go update the badges on all repos, 😅 that'll be fun.

Documentation coverage statistics increases the build times by more than 3x, which is not possible in some repos (like DiffEqSensitivity), but we should enable it where we can.

Strict mode for documenter is still necessary in a few repos, and that can happen in a case-by-case basis. NeuralPDE.jl is the next big one I'll be doing (and that may need to split parallelize those tests onto multiple CI to get below 3 hours), and then the DiffEqDocs. But there's a lot of other smaller ones that can probably be done in an hour or so (RecursiveArrayTools, LinearSolve, NonlinearSolve, Integrals, ...)

@ArnoStrouwen
Copy link
Member

Most of the packages in the numerical utilities group just point toward a readme, because they don't have docs.
I think this should be standardized also.

@ArnoStrouwen
Copy link
Member

I badged and doc covered most of the repos.

@ChrisRackauckas
Copy link
Member Author

I think the rest of the @exampleing can be done on a repo-by-repo basis. I think it's just MTK and DiffEqDocs now.

Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants