ci(buildkite): run builds on PRs opened from forks as well #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the buildkite jobs wouldn't launch for PRs that were opened on forks, because the `smooth-checkout` plugin would not be able to find a valid refspec[^1]. This fixes this up for the most general cases, i.e., when a build is kicked off because a PR is opened or more commits are added on to the PR, and is not expected to work when builds are explicitly triggered (through the Web UI) for the `HEAD` commit. [^1]: https://buildkite.com/julialang/scimldocs/builds/3324#018cb654-71a9-4ce3-9af3-d7e21d044397/101-119
ChrisRackauckas
approved these changes
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the buildkite jobs wouldn't launch for PRs that were opened on forks, because the
smooth-checkoutplugin would not be able to find a valid refspec1. This fixes this up for the most general cases, i.e., when a build is kicked off because a PR is opened or more commits are added on to the PR, and is not expected to work when builds are explicitly triggered (through the Web UI) for theHEADcommit.Footnotes
https://buildkite.com/julialang/scimldocs/builds/3324#018cb654-71a9-4ce3-9af3-d7e21d044397/101-119 ↩