From b36024f594ffb91dd590724f86fdee74c7b648c1 Mon Sep 17 00:00:00 2001 From: Anant Thazhemadam Date: Tue, 30 Jan 2024 15:15:04 +0530 Subject: [PATCH] ci(buildkite): run builds on PRs opened from forks as well Previously, the buildkite jobs wouldn't launch for PRs that were opened on forks, because the `smooth-checkout` plugin would not be able to find a valid refspec[^1]. This fixes this up for the most general cases, i.e., when a build is kicked off because a PR is opened or more commits are added on to the PR, and is not expected to work when builds are explicitly triggered (through the Web UI) for the `HEAD` commit. [^1]: https://buildkite.com/julialang/scimldocs/builds/3324#018cb654-71a9-4ce3-9af3-d7e21d044397/101-119 --- .buildkite/0_webui.yml | 6 ++++++ .buildkite/aggregate.yml | 1 + .buildkite/aggregate.yml.signature | 2 +- .buildkite/documentation.yml | 1 + 4 files changed, 9 insertions(+), 1 deletion(-) diff --git a/.buildkite/0_webui.yml b/.buildkite/0_webui.yml index 33c924e4b46..e28cfb00951 100644 --- a/.buildkite/0_webui.yml +++ b/.buildkite/0_webui.yml @@ -1,6 +1,12 @@ steps: - label: ":rocket: Launch Pipeline!" plugins: + - hasura/smooth-checkout#v4.4.1: + repos: + - config: + - url: "https://github.com/SciML/SciMLDocs.git" + ref: "${BUILDKITE_COMMIT}" + clone_flags: "--depth=1" - staticfloat/cryptic#v2: signed_pipelines: - pipeline: .buildkite/aggregate.yml diff --git a/.buildkite/aggregate.yml b/.buildkite/aggregate.yml index a440bf8dd2c..a7ff803a0de 100644 --- a/.buildkite/aggregate.yml +++ b/.buildkite/aggregate.yml @@ -9,6 +9,7 @@ steps: repos: - config: - url: "https://github.com/SciML/SciMLDocs.git" + ref: "${BUILDKITE_COMMIT}" clone_flags: "--depth=1" - staticfloat/cryptic#v2: diff --git a/.buildkite/aggregate.yml.signature b/.buildkite/aggregate.yml.signature index 60dab8740d3..899fba1cfe8 100644 --- a/.buildkite/aggregate.yml.signature +++ b/.buildkite/aggregate.yml.signature @@ -1 +1 @@ -Salted__CeNFmA{2KJ5d0o\D@D{]$%'iXj'|G$9VAU]7&y0q\{Wk7 \ No newline at end of file +Salted__fǗ{/qOw{bx'0PSM}Kf*-7, IQO|A&VňzQI8RG# \ No newline at end of file diff --git a/.buildkite/documentation.yml b/.buildkite/documentation.yml index a9b90cac8db..bb81ecf90bb 100644 --- a/.buildkite/documentation.yml +++ b/.buildkite/documentation.yml @@ -7,6 +7,7 @@ steps: repos: - config: - url: "https://github.com/SciML/SciMLDocs.git" + ref: "${BUILDKITE_COMMIT}" clone_flags: "--depth=1" command: |