Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requiring parameters to be AbstractVectors #48

Open
lindnemi opened this issue Feb 26, 2021 · 1 comment
Open

Requiring parameters to be AbstractVectors #48

lindnemi opened this issue Feb 26, 2021 · 1 comment

Comments

@lindnemi
Copy link

I think here you are implicitly requiring u0 and p to be AbstractVectors. Hence you might aswell dispatch on that. E.g. this uses tuple parameters and throws an error:

expectation(x -> 1, 
            ODEProblem((a,b,c,d) -> nothing, [1.], (0., 1.), nothing),
            [1.,1.],
            (Uniform(-1,1), 0.), # tuple params
            Koopman(),
            Tsit5())
@ChrisRackauckas
Copy link
Member

I see. Yes, that would be good to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants