Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename isconvertible -> isconcretizable #212

Open
gaurav-arya opened this issue Jul 21, 2023 · 4 comments
Open

Rename isconvertible -> isconcretizable #212

gaurav-arya opened this issue Jul 21, 2023 · 4 comments

Comments

@gaurav-arya
Copy link
Member

More of a mouthful, but the consistency seems worth it
@gaurav-arya
Copy link
Member Author

On the other hand, it's not a word :/ OK this is just bikeshedding for now

@gaurav-arya
Copy link
Member Author

gaurav-arya commented Jul 21, 2023 •
edited
Loading

https://en.wikipedia.org/wiki/Concrete_category#Definition

@vpuri3
Copy link
Member

vpuri3 commented Jul 21, 2023

what's the final word?

@gaurav-arya
Copy link
Member Author

I think we should wait until the WOperator PR, for isconvertible to get some mileage in OrdinaryDiffEq. As I think there's still some more thinking to do on the semantics, which would of course inform the name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vpuri3 @gaurav-arya