From 3088effe489e843baac3e9d35c0d52d9250b74e7 Mon Sep 17 00:00:00 2001 From: pogudingleb Date: Sun, 28 Jan 2024 00:07:08 +0100 Subject: [PATCH] fixing QA --- .github/workflows/SpellCheck.yml | 13 +++++++++++++ .typos.toml | 2 ++ Project.toml | 2 +- ext/ModelingToolkitExt.jl | 1 + src/StructuralIdentifiability.jl | 2 +- test/qa.jl | 12 ++++++++++++ 6 files changed, 30 insertions(+), 2 deletions(-) create mode 100644 .github/workflows/SpellCheck.yml create mode 100644 .typos.toml create mode 100644 test/qa.jl diff --git a/.github/workflows/SpellCheck.yml b/.github/workflows/SpellCheck.yml new file mode 100644 index 00000000..3ccc0e5a --- /dev/null +++ b/.github/workflows/SpellCheck.yml @@ -0,0 +1,13 @@ +iname: Spell Check + + on: [pull_request] + + jobs: + typos-check: + name: Spell Check with Typos + runs-on: ubuntu-latest + steps: + - name: Checkout Actions Repository + uses: actions/checkout@v3 + - name: Check spelling + uses: crate-ci/typos@v1.16.23 diff --git a/.typos.toml b/.typos.toml new file mode 100644 index 00000000..aa9a6283 --- /dev/null +++ b/.typos.toml @@ -0,0 +1,2 @@ +[default.extend-words] + numer = "numer" diff --git a/Project.toml b/Project.toml index 9d3d09d9..e41d635c 100644 --- a/Project.toml +++ b/Project.toml @@ -18,7 +18,6 @@ ParamPunPam = "3e851597-e36f-45a9-af0a-b7781937992f" PrecompileTools = "aea7be01-6a6a-4083-8856-8a6e6704d82a" Primes = "27ebfcd6-29c5-5fa9-bf4b-fb8fc14df3ae" Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c" -SpecialFunctions = "276daf66-3868-5448-9aa4-cd146d93841b" TimerOutputs = "a759f4b9-e2f1-59dc-863e-4aeb61b1ea8f" [weakdeps] @@ -61,6 +60,7 @@ Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595" CPUSummary = "2a0fbf3d-bb9c-48f3-b0a9-814d99fd7ab9" ModelingToolkit = "961ee093-0014-501f-94e3-6117800e7a78" Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f" +SpecialFunctions = "276daf66-3868-5448-9aa4-cd146d93841b" SymbolicUtils = "d1185830-fcd6-423d-90d6-eec64667417b" Symbolics = "0c5d862f-8b57-4792-8d23-62f2024744c7" Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40" diff --git a/ext/ModelingToolkitExt.jl b/ext/ModelingToolkitExt.jl index 4ca8de85..33447508 100644 --- a/ext/ModelingToolkitExt.jl +++ b/ext/ModelingToolkitExt.jl @@ -15,6 +15,7 @@ else using ..ModelingToolkit end +export mtk_to_si export assess_local_identifiability, assess_identifiability, find_identifiable_functions # ------------------------------------------------------------------------------ diff --git a/src/StructuralIdentifiability.jl b/src/StructuralIdentifiability.jl index a18c9828..f5a8cb8e 100644 --- a/src/StructuralIdentifiability.jl +++ b/src/StructuralIdentifiability.jl @@ -21,7 +21,7 @@ using ParamPunPam: reduce_mod_p!, specialize_mod_p, AbstractBlackboxIdeal ParamPunPam.enable_progressbar(false) # defining a model -export ODE, @ODEmodel, @DDSmodel, mtk_to_si +export ODE, @ODEmodel, @DDSmodel # assessing identifiability export assess_local_identifiability, assess_identifiability diff --git a/test/qa.jl b/test/qa.jl new file mode 100644 index 00000000..6cf40ac9 --- /dev/null +++ b/test/qa.jl @@ -0,0 +1,12 @@ +using StructuralIdentifiability, Aqua +@testset "Aqua" begin + Aqua.find_persistent_tasks_deps(StructuralIdentifiability) + Aqua.test_ambiguities(StructuralIdentifiability, recursive = false) + Aqua.test_deps_compat(StructuralIdentifiability) + Aqua.test_piracies(StructuralIdentifiability, + treat_as_own = []) + Aqua.test_project_extras(StructuralIdentifiability) + Aqua.test_stale_deps(StructuralIdentifiability) + Aqua.test_unbound_args(StructuralIdentifiability) + Aqua.test_undefined_exports(StructuralIdentifiability) +end