Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: add new compat entry for Combinatorics at version 1, (keep existing compat) #214

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 4, 2023

This pull request sets the compat entry for the Combinatorics package to 1.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.
Note: Consider registering a new release of your package immediately after merging this PR, as downstream packages may depend on this for tests to pass.

@ChrisRackauckas ChrisRackauckas force-pushed the compathelper/new_version/2023-10-04-00-09-19-309-00290718220 branch from cf64877 to ebc1131 Compare October 4, 2023 00:09
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #214 (ebc1131) into master (53d1b5d) will decrease coverage by 28.39%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           master     #214       +/-   ##
===========================================
- Coverage   90.91%   62.53%   -28.39%     
===========================================
  Files          24       24               
  Lines        3105     3099        -6     
===========================================
- Hits         2823     1938      -885     
- Misses        282     1161      +879     

see 20 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pogudingleb pogudingleb merged commit c0b16a2 into master Oct 4, 2023
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant