Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render ModelingToolkit as an extension #266

Merged
merged 36 commits into from
Jan 26, 2024
Merged

Render ModelingToolkit as an extension #266

merged 36 commits into from
Jan 26, 2024

Conversation

pogudingleb
Copy link
Collaborator

@pogudingleb pogudingleb commented Jan 17, 2024

The goals are:

  • increase loading time if the MTK interface is not used
  • allow testing and releasing for earlier versions of Julia than 1.10

Todo:

  • separate the code to an extension (kind-of done)
  • arrange the tests with different Julia versions (kind-of done)
  • fix the docs (kind-of done)
  • switch to the new finite fields (done)
  • create an additional non-MTK interface for discrete-time systems (kind-of done)

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (7633afd) 89.90% compared to head (aad9b56) 89.84%.
Report is 2 commits behind head on master.

Files Patch % Lines
ext/ModelingToolkitExt.jl 90.16% 18 Missing ⚠️
src/input_macro.jl 90.59% 11 Missing ⚠️
src/util.jl 84.21% 3 Missing ⚠️
src/ODEexport.jl 0.00% 2 Missing ⚠️
src/discrete.jl 98.59% 1 Missing ⚠️
src/parametrizations.jl 83.33% 1 Missing ⚠️
src/wronskian.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #266      +/-   ##
==========================================
- Coverage   89.90%   89.84%   -0.07%     
==========================================
  Files          25       27       +2     
  Lines        3209     3268      +59     
==========================================
+ Hits         2885     2936      +51     
- Misses        324      332       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

seed = 42,
with_states = false,
simplify = :standard,
rational_interpolator = :VanDerHoevenLecerf,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for future me: hide the interpolation parameters

src/discrete.jl Outdated Show resolved Hide resolved
src/discrete.jl Outdated Show resolved Hide resolved
@sumiya11
Copy link
Collaborator

sumiya11 commented Jan 25, 2024

I seem to have some issues with dependencies on 1.9.4:

(si-1.9) pkg> add ModelingToolkit
(si-1.9) pkg> dev .
   Resolving package versions...
ERROR: Unsatisfiable requirements detected for package Symbolics [0c5d862f]:
 Symbolics [0c5d862f] log:
 ├─possible versions are: 0.1.0-5.16.1 or uninstalled
 ├─restricted to versions 5.16.0-5 by StructuralIdentifiability [220ca800], leaving only versions: 5.16.0-5.16.1 or uninstalled      
 │ └─StructuralIdentifiability [220ca800] log:
 │   ├─possible versions are: 0.5.1 or uninstalled
 │   └─StructuralIdentifiability [220ca800] is fixed to version 0.5.1
 ├─restricted by julia compatibility requirements to versions: 0.1.0-5.14.1 or uninstalled, leaving only versions: uninstalled       
 └─restricted by compatibility requirements with ModelingToolkit [961ee093] to versions: 5.7.0-5.16.1 — no versions left
   └─ModelingToolkit [961ee093] log:
     ├─possible versions are: 0.0.1-8.75.0 or uninstalled
     ├─restricted to versions 8.74.0-8 by StructuralIdentifiability [220ca800], leaving only versions: 8.74.0-8.75.0 or uninstalled  
     │ └─StructuralIdentifiability [220ca800] log: see above
     └─restricted to versions * by an explicit requirement, leaving only versions: 8.74.0-8.75.0

UPD:

(si-1.9) pkg> st
Status `C:\data\projects\SI2\si-1.9\Project.toml`
  [961ee093] ModelingToolkit v8.75.0

@pogudingleb
Copy link
Collaborator Author

I seem to have some issues with dependencies on 1.9.4:

(si-1.9) pkg> add ModelingToolkit
(si-1.9) pkg> dev .
   Resolving package versions...
ERROR: Unsatisfiable requirements detected for package Symbolics [0c5d862f]:
 Symbolics [0c5d862f] log:
 ├─possible versions are: 0.1.0-5.16.1 or uninstalled
 ├─restricted to versions 5.16.0-5 by StructuralIdentifiability [220ca800], leaving only versions: 5.16.0-5.16.1 or uninstalled      
 │ └─StructuralIdentifiability [220ca800] log:
 │   ├─possible versions are: 0.5.1 or uninstalled
 │   └─StructuralIdentifiability [220ca800] is fixed to version 0.5.1
 ├─restricted by julia compatibility requirements to versions: 0.1.0-5.14.1 or uninstalled, leaving only versions: uninstalled       
 └─restricted by compatibility requirements with ModelingToolkit [961ee093] to versions: 5.7.0-5.16.1 — no versions left
   └─ModelingToolkit [961ee093] log:
     ├─possible versions are: 0.0.1-8.75.0 or uninstalled
     ├─restricted to versions 8.74.0-8 by StructuralIdentifiability [220ca800], leaving only versions: 8.74.0-8.75.0 or uninstalled  
     │ └─StructuralIdentifiability [220ca800] log: see above
     └─restricted to versions * by an explicit requirement, leaving only versions: 8.74.0-8.75.0

UPD:

(si-1.9) pkg> st
Status `C:\data\projects\SI2\si-1.9\Project.toml`
  [961ee093] ModelingToolkit v8.75.0

Yes, the necessary version of Symbolics requires Julia 1.10, so the extension will not work on lower versions. I am not sure if there is anything I can do with this

@pogudingleb pogudingleb merged commit 590f5be into master Jan 26, 2024
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants