Correct initial saved value for dures
#430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were saving `u` twice rather than `du` at the start. While we're at it, also defer the choice of the interpolator to the SciMLBase code (which does the same thing currently, but let's have this in one place and give the SciMLBase constructor access to the `du` vector if we have it).
Codecov Report
@@ Coverage Diff @@
## master #430 +/- ##
=======================================
Coverage 81.80% 81.80%
=======================================
Files 11 11
Lines 1440 1440
=======================================
Hits 1178 1178
Misses 262 262
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
oscardssmith
approved these changes
Oct 25, 2023
|
Add a test? |
|
Test case added. |
|
Test added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were saving
utwice rather thanduat the start. While we're at it, also defer the choice of the interpolator to the SciMLBase code (which does the same thing currently, but let's have this in one place and give the SciMLBase constructor access to theduvector if we have it).