feat!: indexing rework #12
Conversation
AayushSabharwal
requested review from
ChrisRackauckas,
oscardssmith and
YingboMa
docs/src/api.md
Outdated
| isindependent_variable | ||
| isobserved | ||
| observed | ||
| istimedependent |
There was a problem hiding this comment.
the naming/underscore placement here seems slightly inconsistent
There was a problem hiding this comment.
isindependentvariable feels unreadable to me. Maybe isindepvar?
There was a problem hiding this comment.
Fixed in 9bea164
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #12 +/- ##
=========================================
+ Coverage 0.00% 1.06% +1.06%
=========================================
Files 2 5 +3
Lines 33 94 +61
=========================================
+ Hits 0 1 +1
- Misses 33 93 +60 ☔ View full report in Codecov by Sentry. |
src/SymbolicIndexingInterface.jl
Outdated
| """ | ||
| issymbolic(x) = issymbolic(typeof(x)) | ||
| issymbolic(::Type) = NotSymbolic() | ||
| issymbolic(::Type{Symbol}) = Symbolic() |
There was a problem hiding this comment.
Is there more possibilities than true/false from issymbolic?
There was a problem hiding this comment.
I was considering adding a SymbolicArray trait variant, for SymArr and AbstractArray{<:something that implements Symbolic} but it's just as easy to check all(isequal(Symbolic()), issymbolic.(collect(sym))). Apart from that I think it's just true/false
- add has_static_variable function - make variable names more consistent
AayushSabharwal
force-pushed
the
as/indexing-rework
branch
from
6f52d2b to
1e5450b
Compare
|
🎉 |
Completely rework the indexing API, with tests