Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"DiffEqArray Indexing Tests" from RecursiveArrayTools not included in downstream testing #31

Closed
ArnoStrouwen opened this issue Jan 7, 2024 · 2 comments · Fixed by #54
Closed

"DiffEqArray Indexing Tests" from RecursiveArrayTools not included in downstream testing #31

ArnoStrouwen opened this issue Jan 7, 2024 · 2 comments · Fixed by #54
Labels
bug Something isn't working

Comments

@ArnoStrouwen
Copy link
Member

Not sure if it is intentional that these tests are not included:
https://github.com/SciML/RecursiveArrayTools.jl/blob/0e877e32b89dd13159c11b1ff4eeba4aa3b80302/test/runtests.jl#L63-L64
@ArnoStrouwen ArnoStrouwen added the bug Something isn't working label Jan 7, 2024
@ChrisRackauckas
Copy link
Member

@AayushSabharwal was this addressed?

@AayushSabharwal
Copy link
Member

No, I'll PR to fix it. It looks like we run Core RAT in downstream tests which isn't particularly useful.

@AayushSabharwal AayushSabharwal mentioned this issue Mar 8, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: run SII testset in RAT downstream tests SciML/SymbolicIndexingInterface.jl
3 participants
@ChrisRackauckas @ArnoStrouwen @AayushSabharwal