feat: improve getu/setu/getp/setp handling of nested variables #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #33 +/- ##
==========================================
- Coverage 32.59% 28.35% -4.24%
==========================================
Files 7 7
Lines 181 201 +20
==========================================
- Hits 59 57 -2
- Misses 122 144 +22 ☔ View full report in Codecov by Sentry. |
- also addresses type-stability of the closures returned from the above functions
AayushSabharwal
force-pushed
the
as/getu-improved
branch
from
f14bd94 to
55eca79
Compare
Datseris
added a commit
to JuliaDynamics/DynamicalSystemsBase.jl
that referenced
this pull request
Jan 16, 2024
Requires SciML/SymbolicIndexingInterface.jl#33 to be merged!
YingboMa
approved these changes
Jan 16, 2024
AayushSabharwal
force-pushed
the
as/getu-improved
branch
from
48461a4 to
07d1e73
Compare
Datseris
added a commit
to JuliaDynamics/DynamicalSystemsBase.jl
that referenced
this pull request
Jan 25, 2024
…m and get state (#190) * fix the successful step function not having nan * mtk integration works * improve docs * get state also works with symbolics! * add changelog * add MTK to test deps * mention MTK interfacing in CoupledODEs * rename current_state to observe_State * MTK works woth stroboscopic * ProjectedDS works as well * remove unecessary set_parameter extensions * finish MTK integration * export the function referrencing the system * use getu/setu directly on numeric containers Requires SciML/SymbolicIndexingInterface.jl#33 to be merged! * make sure tests pass * simplify referrenced sys function: we only need sys now * all tests pass! * finish changelog * better/clearer handling of observation index * use the referrenced SciML Problem instead of System! * correct retrieval of referrenced system * allow `set_u` to set a specific component of the system! with symbolic! * make sure function is only used with core systems * Throw error if no referrenced MTK * simplify set_state!@ * fix set state for parallel systems * request merged and tagged functionality * trigger tests * fix tests * update docs * finish changelog * correct set_paramters! * remove examples from index * fix stroboscopic tests * fix successful step tests * fix docs!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.